Merge pull request #77 from microsoftgraph/caitbal/working

Remove redundant PHP model constructors

Author: Caitlin Bales (MSFT)

Templates/PHP/Model/ComplexType.php.tt

@@ -12,28 +12,6 @@ namespace Microsoft\Graph\Model;
 <#=writer.GetClassBlock(complex.Name.ToCheckedCase().ToString(), "Model")#>
 class <#=complex.Name.ToCheckedCase()#> extends Entity
 {
-    /**
-    * The array of properties available 
-    * to the model
-    *
-    * @var array(string => string)
-    */
-    private $_propDict;
-    /**
-    * <#=complex.Name.ToCheckedCase()#> constructor
-    *
-    * @param array $propDict List of properties to set
-    * Defaults to an empty array
-    *
-    * @return <#=complex.Name.ToCheckedCase()#>
-    */
-    public function __construct($propDict=array())
-    {
-        parent::__construct();
-        $this->_propDict = $propDict;
-        return $this;
-    }
-
     /**
     * Gets the property dictionary of the <#=complex.Name.ToCheckedCase()#>
     *

Templates/PHP/Model/EntityType.php.tt

@@ -25,34 +25,29 @@ class <#=entity.Name.ToCheckedCase()#> extends Entity
 }
 #>
 {
+<#
+if (entity.Name.ToCheckedCase() == "Entity") {
+#>
     /**
     * The array of properties available
     * to the model
     *
     * @var array(string => string)
     */
-    private $_propDict;
+    protected $_propDict;
 
     /**
     * Construct a new <#=entity.Name.ToCheckedCase()#>
     *
     * @param array $propDict A list of properties to set
-    *
-    * @return <#=entity.Name.ToCheckedCase()#>
     */
     function __construct($propDict = array())
     {
-<#
-if (!(entity.Name.ToCheckedCase() == "Entity")) {
-#>
-        parent::__construct();
+		$this->_propDict = $propDict;
+    }
 <#
 }
 #>
-        $this->_propDict = $propDict;
-        return $this;
-    }
-
     /**
     * Gets the property dictionary of the <#=entity.Name.ToUpperFirstChar()#>
     *
@@ -70,11 +65,11 @@ foreach(var property in entity.Properties.Where(prop => prop.Type.GetTypeString(
         if (property.IsCollection()) {
 #>
 
-    /** 
-    * Gets the <#=property.Name#>
-    *
-    * @return array The <#=property.Name#>
-    */
+     /** 
+     * Gets the <#=property.Name#>
+     *
+     * @return array The <#=property.Name#>
+     */
     public function get<#=property.Name.ToCheckedCase()#>()
     {
         if (array_key_exists("<#=property.Name.ToCamelize()#>", $this->_propDict)) {