Skip to content

Commit 2a392f0

Browse files
authored
Merge pull request #174 from microsoftgraph/extensions-generated-java-merging
Extensions-generated java merging
2 parents f9c8854 + a6caca6 commit 2a392f0

File tree

94 files changed

+398
-898
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

94 files changed

+398
-898
lines changed

Templates/Java/BaseJavaModel.template.tt

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -234,9 +234,13 @@
234234
}
235235

236236
public string BaseTypeCollectionResponse(OdcmObject c) {
237-
return "Base" + TypeName(c) + "CollectionResponse";
237+
return TypeCollectionResponse(c);
238238
}
239239

240+
public string TypeCollectionResponse(OdcmObject c) {
241+
return TypeName(c) + "CollectionResponse";
242+
}
243+
240244
public string TypeCollectionRequest(OdcmObject c) {
241245
if(c is OdcmProperty && c.AsOdcmProperty().IsReference()){
242246
return TypeCollectionWithReferencesRequest(c);
@@ -502,9 +506,9 @@
502506

503507
public string CollectionRequestGeneric(OdcmObject c) {
504508
if (c is OdcmMethod) {
505-
return "<" + BaseTypeCollectionResponse(c) + ", " + ITypeCollectionPage(c) + ">";
509+
return "<" + TypeCollectionResponse(c) + ", " + ITypeCollectionPage(c) + ">";
506510
}
507-
return "<" + BaseTypeCollectionResponse(c) + ", " + ITypeCollectionPage(c) + ">";
511+
return "<" + TypeCollectionResponse(c) + ", " + ITypeCollectionPage(c) + ">";
508512
}
509513

510514
//Creating package definition for Enum.java.tt template file
@@ -527,7 +531,7 @@
527531
if(propertyName == "BaseItem" || propertyName == "BaseItemVersion")
528532
return "models.extensions";
529533
else
530-
return "models.generated";
534+
return "models.extensions";
531535
}
532536

533537
return "models.extensions";
@@ -540,7 +544,7 @@
540544
return "requests.extensions";
541545

542546
if(propertyName.StartsWith("Base") || propertyName.StartsWith("IBase"))
543-
return "requests.generated";
547+
return "requests.extensions";
544548

545549
return "requests.extensions";
546550
}
@@ -900,7 +904,7 @@ import java.util.EnumSet;", host.CurrentModel.NamespaceName());
900904
if(property.Type is OdcmPrimitiveType)
901905
continue;
902906

903-
var propertyType = BaseTypeCollectionResponse(property);
907+
var propertyType = TypeCollectionResponse(property);
904908
string importstr= String.Format(importFormat,
905909
host.CurrentModel.NamespaceName(),
906910
getPrefixForRequests(propertyType),
@@ -936,7 +940,6 @@ import {0}.models.extensions.*;
936940
import {0}.models.generated.*;
937941
import {0}.http.*;
938942
import {0}.requests.extensions.*;
939-
import {0}.requests.generated.*;
940943
import {0}.options.*;
941944
import {0}.serializer.*;
942945

@@ -988,12 +991,7 @@ public {1} {2}{3}{4} {{";
988991
extendsStr,
989992
implementsStr);
990993

991-
if (name.StartsWith("Base") || name.StartsWith("IBase"))
992-
{
993-
return CreatAutogeneratedWarning() + declaration;
994-
}
995-
996-
return CreateExtensiblityMessage() + declaration;
994+
return CreatAutogeneratedWarning() + declaration;
997995
}
998996

999997
public string GenericRequest(OdcmObject c){
@@ -1188,7 +1186,7 @@ public {1} {2}{3}{4} {{";
11881186
}}
11891187
",
11901188
property.Name.SanitizePropertyName(property),
1191-
BaseTypeCollectionResponse(property),
1189+
TypeCollectionResponse(property),
11921190
TypeCollectionPage(property),
11931191
property.GetTypeString());
11941192
}

Templates/Java/models_generated/BaseEntity.java.tt renamed to Templates/Java/models_extensions/BaseEntity.java.tt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
<#@ template debug="true" hostspecific="true" language="C#" #>
33
<#@ include file="BaseJavaModel.template.tt"#>
44
<#@ output extension="\\" #>
5+
<#host.TemplateName = TypeName(c);#>
56
<#=writer.WriteHeader()#>
67
<#=CreatePackageDefForEntity(host)#>
78

@@ -11,7 +12,7 @@ import com.google.gson.annotations.*;
1112
import java.util.HashMap;
1213
import java.util.Map;
1314

14-
<#=CreateClassDef(BaseTypeName(c), BaseClassName(c), "IJsonBackedObject")#>
15+
<#=CreateClassDef(TypeName(c), BaseClassName(c), "IJsonBackedObject")#>
1516

1617
<#
1718
if(((OdcmClass)c).Base == null){
@@ -33,4 +34,4 @@ import java.util.Map;
3334
<#=CreatePropertyDef(((OdcmClass)c).Properties, c is OdcmComplexClass)#>
3435
<#=CreateRawJsonObject()#>
3536
<#=UpdatePropertiesWithinSetRawObject(((OdcmClass)c).Properties, c is OdcmComplexClass)#>
36-
<#=PostProcess(BaseTypeName(c))#>}
37+
<#=PostProcess(TypeName(c))#>}

Templates/Java/models_generated/BaseMethodBody.java.tt renamed to Templates/Java/models_extensions/BaseMethodBody.java.tt

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,17 @@
22
<#@ template debug="true" hostspecific="true" language="C#" #>
33
<#@ include file="BaseJavaModel.template.tt"#>
44
<#@ output extension="\\" #>
5-
<#host.TemplateName = BaseTypeBody(c);#>
5+
<#host.TemplateName = TypeBody(c);#>
66
<#=writer.WriteHeader()#>
77
<#=CreatePackageDefinition(host)#>
8-
8+
import com.microsoft.graph.models.generated.*;
99
import com.google.gson.annotations.Expose;
1010
import com.google.gson.annotations.SerializedName;
1111
import com.google.gson.JsonObject;
1212
import com.microsoft.graph.serializer.ISerializer;
13-
import com.microsoft.graph.models.extensions.*;
1413
import java.util.EnumSet;
1514

16-
<#=CreateClassDef(BaseTypeBody(c))#>
15+
<#=CreateClassDef(TypeBody(c))#>
1716

1817
<#=CreateParameterDef(c.AsOdcmMethod().Parameters)#>
1918
<#=CreateRawJsonObject()#>

Templates/Java/models_extensions/ExtensibleEntity.java.tt

Lines changed: 0 additions & 9 deletions
This file was deleted.
File renamed without changes.

Templates/Java/models_extensions/IClient.java.tt

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,16 @@
22
<#@ template debug="true" hostspecific="true" language="C#" #>
33
<#@ include file="BaseJavaModel.template.tt"#>
44
<#@ output extension="\\" #>
5+
<#host.TemplateName = IClientType(c);#>
56
<#=writer.WriteHeader()#>
67
<#=CreatePackageDef(host)#>
8+
import com.google.gson.JsonObject;
79

810
<#=CreateInterfaceDef(IClientType(c), IBaseClientType(c))#>
9-
11+
<# if(host.TemplateName.Equals("IGraphServiceClient")){ #>
12+
13+
<T> CustomRequestBuilder<T> customRequest(final String url, final Class<T> responseType);
14+
15+
CustomRequestBuilder<JsonObject> customRequest(final String url);
16+
<# } #>
1017
}

Templates/Java/models_extensions/MethodBody.java.tt

Lines changed: 0 additions & 14 deletions
This file was deleted.
File renamed without changes.

Templates/Java/requests_generated/BaseEntityCollectionPage.java.tt renamed to Templates/Java/requests_extensions/BaseEntityCollectionPage.java.tt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,23 +2,23 @@
22
<#@ template debug="true" hostspecific="true" language="C#" #>
33
<#@ include file="BaseJavaModel.template.tt"#>
44
<#@ output extension="\\" #>
5+
<#host.TemplateName = TypeCollectionPage(c);#>
56
<#=writer.WriteHeader()#>
6-
<#=CreatAutogeneratedWarning()#>
77
<#=CreatePackageDefForBaseEntityCollectionPage(host)#>
88
import com.microsoft.graph.http.BaseCollectionPage;
99

10-
<#=CreateClassDef(BaseTypeCollectionPage(c), "BaseCollectionPage" + CollectionPageGeneric(c), IBaseTypeCollectionPage(c))#>
10+
<#=CreateClassDef(TypeCollectionPage(c), "BaseCollectionPage" + CollectionPageGeneric(c), ITypeCollectionPage(c))#>
1111
<#
1212
String s = TypeName(c);
1313
#>
1414

1515
/**
1616
* A collection page for <#=TypeName(c)#>
1717
*
18-
* @param response the serialized <#=BaseTypeCollectionResponse(c)#> from the service
18+
* @param response the serialized <#=TypeCollectionResponse(c)#> from the service
1919
* @param builder the request builder for the next collection page
2020
*/
21-
public <#=BaseTypeCollectionPage(c)#>(final <#=BaseTypeCollectionResponse(c)#> response, final <#=ITypeCollectionRequestBuilder(c)#> builder) {
21+
public <#=TypeCollectionPage(c)#>(final <#=TypeCollectionResponse(c)#> response, final <#=ITypeCollectionRequestBuilder(c)#> builder) {
2222
super(response.value, builder);
2323
}
2424
}

Templates/Java/requests_generated/BaseEntityCollectionReferenceRequest.java.tt renamed to Templates/Java/requests_extensions/BaseEntityCollectionReferenceRequest.java.tt

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,11 @@
22
<#@ template debug="true" hostspecific="true" language="C#" #>
33
<#@ include file="BaseJavaModel.template.tt"#>
44
<#@ output extension="\\" #>
5-
<#host.TemplateName = BaseTypeCollectionReferenceRequest(c);#>
5+
<#host.TemplateName = TypeCollectionReferenceRequest(c);#>
66
<#=writer.WriteHeader()#>
7-
<#=CreatAutogeneratedWarning()#>
87
<#=CreatePackageDef(host)#>
98

10-
<#=CreateClassDef(BaseTypeCollectionReferenceRequest(c), "BaseCollectionRequest" + CollectionRequestGeneric(c), IBaseTypeCollectionReferenceRequest(c))#>
9+
<#=CreateClassDef(TypeCollectionReferenceRequest(c), "BaseCollectionRequest" + CollectionRequestGeneric(c), ITypeCollectionReferenceRequest(c))#>
1110

1211
/**
1312
* The request builder for this collection of <#=TypeName(c)#>
@@ -16,8 +15,8 @@
1615
* @param client the service client
1716
* @param requestOptions the options for this request
1817
*/
19-
public <#=BaseTypeCollectionReferenceRequest(c)#>(final String requestUrl, <#=IBaseClientType()#> client, final java.util.List<? extends Option> requestOptions) {
20-
super(requestUrl, client, requestOptions, <#=BaseTypeCollectionResponse(c)#>.class, <#=ITypeCollectionPage(c)#>.class);
18+
public <#=TypeCollectionReferenceRequest(c)#>(final String requestUrl, <#=IBaseClientType()#> client, final java.util.List<? extends Option> requestOptions) {
19+
super(requestUrl, client, requestOptions, <#=TypeCollectionResponse(c)#>.class, <#=ITypeCollectionPage(c)#>.class);
2120
}
2221

2322
public void post(final <#=TypeName(c)#> new<#=TypeName(c)#>, final ICallback<<#=TypeName(c)#>> callback) {

0 commit comments

Comments
 (0)