Code cleanup based on Roberts comments, no .d.ts changes

Author: dan-silver

Templates/TypeScript/src/entity_types.ts.tt

@@ -18,15 +18,15 @@
 
 
 <# foreach(var enumType in enumTypes) { #>
-export type <#= writer.UpperCaseFirstChar(enumType.Name) #> = <#= enumType.GetEnumValues() #>
+export type <#= enumType.Name.UpperCaseFirstChar() #> = <#= enumType.GetEnumValues() #>
 <# } #>
 <#
   foreach(var entityType in entityTypes)
     {
         var methods = entityType.Methods;
 #>
 
-export interface <#= writer.UpperCaseFirstChar(entityType.Name) #><# if (entityType.Base != null) { #> extends <#=  writer.UpperCaseFirstChar(entityType.Base.Name) #><# }#> {
+export interface <#= entityType.Name.UpperCaseFirstChar() #><# if (entityType.Base != null) { #> extends <#=  entityType.Base.Name.UpperCaseFirstChar() #><# }#> {
 <# foreach(var prop in entityType.Properties.ToList()) { #>
     <#=  prop.Name #>?: <#= prop.GetTypeString() #>
 <# } #>
@@ -39,7 +39,7 @@ export interface <#= writer.UpperCaseFirstChar(entityType.Name) #><# if (entityT
   {
 #>
 
-export interface <#= writer.UpperCaseFirstChar(complexType.Name)#> {
+export interface <#= complexType.Name.UpperCaseFirstChar()#> {
 <# foreach(var prop in complexType.Properties) { #>
       <#= prop.Name #>?: <#= prop.GetTypeString() #>
 <# } #>

src/GraphODataTemplateWriter/CodeHelpers/TypeScript/CodeWriterTypeScript.cs

@@ -30,10 +30,6 @@ public override String NewLineCharacter
         {
             get { return "\n"; }
         }
-        public String UpperCaseFirstChar(String s)
-        {
-            return char.ToUpper(s[0]) + s.Substring(1);
-        }
 
     }
 

src/GraphODataTemplateWriter/CodeHelpers/TypeScript/TypeHelperTypeScript.cs

@@ -4,33 +4,20 @@ namespace Microsoft.Graph.ODataTemplateWriter.CodeHelpers.TypeScript
 {
     using Vipr.Core.CodeModel;
     using System;
-    using System.Collections.Generic;
     using System.Linq;
 
     public static class TypeHelperTypeScript
     {
 
         // enum value string, ex: "low" | "normal" | "high"
         public static String GetEnumValues(this OdcmEnum _enum) {
-            String enumVals = null;
-            foreach (var member in _enum.Members)
-            {
-                if (enumVals == null)
-                {
-                    enumVals = '"' + member.Name + '"';
-                } else
-                {
-                    enumVals += " | " + '"' + member.Name + '"';
-                }
-            }
-
-            return enumVals;
+            return _enum.Members.Select(m => "\"" + m.Name + "\"").Aggregate((cur, next) =>  cur + " | " + next);
         }
 
 
         public static string GetTypeString(this OdcmProperty prop)
         {
-            string typeStr = UpperCaseFirstChar(prop.Type.Name);
+            string typeStr = prop.Type.Name.UpperCaseFirstChar();
 
             switch (typeStr)
             {
@@ -62,7 +49,7 @@ public static string GetTypeString(this OdcmProperty prop)
             return (prop.IsCollection) ? "[" + typeStr + "]" : typeStr;
 
         }
-        public static String UpperCaseFirstChar(String s)
+        public static String UpperCaseFirstChar(this String s)
         {
             return char.ToUpper(s[0]) + s.Substring(1);
         }

src/GraphODataTemplateWriter/PathWriters/TypeScriptPathWriter.cs

@@ -45,9 +45,9 @@ private string CreateNamespace(string folderName)
 
         private string CreatePathFromNamespace(string @namespace)
         {
-            var splittedPaths = @namespace.Split('.');
+            var splitPaths = @namespace.Split('.');
 
-            var destinationPath = splittedPaths.Aggregate(string.Empty, (current, path) =>
+            var destinationPath = splitPaths.Aggregate(string.Empty, (current, path) =>
                                   current + string.Format("{0}{1}", path, Path.DirectorySeparatorChar));
             return destinationPath;
         }