Skip to content

Commit 8911802

Browse files
author
Caitlin Bales (MSFT)
authored
Merge pull request #116 from microsoftgraph/raw-type-cleanup
Update generated Java files to include generic types
2 parents 8e7fe26 + 72e5139 commit 8911802

File tree

4 files changed

+19
-10
lines changed

4 files changed

+19
-10
lines changed

Templates/Java/requests_extensions/EntityRequest.java.tt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,23 +12,23 @@
1212
/**
1313
* The request for the <#=TypeName(c)#>
1414
*
15-
* @param requestUrl The request url
15+
* @param requestUrl The request URL
1616
* @param client The service client
1717
* @param requestOptions The options for this request
18-
* @param responseClass The class of the reponse
18+
* @param responseClass The class of the response
1919
*/
2020
public <#=TypeRequest(c)#>(final String requestUrl,
2121
final <#=IBaseClientType()#> client,
2222
final java.util.List<? extends Option> requestOptions,
23-
final Class responseClass) {
23+
final Class<? extends <#=ClassTypeName(c)#>> responseClass) {
2424
super(requestUrl, client, requestOptions, responseClass);
2525
}
2626
<# } #>
2727

2828
/**
2929
* The request for the <#=TypeName(c)#>
3030
*
31-
* @param requestUrl The request url
31+
* @param requestUrl The request URL
3232
* @param client The service client
3333
* @param requestOptions The options for this request
3434
*/

Templates/Java/requests_extensions/IEntityRequestBuilder.java.tt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,5 @@
77
<#=CreatePackageDef(host)#>
88

99
<#=CreateInterfaceDef(ITypeRequestBuilder(c), IBaseTypeRequestBuilder(c))#>
10+
1011
}

Templates/Java/requests_generated/BaseEntityRequest.java.tt

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,21 +5,29 @@
55
<#host.TemplateName = BaseTypeRequest(c);#>
66
<#=writer.WriteHeader()#>
77
<#=CreatePackageDef(host)#>
8+
<#
9+
String classDeclaration = "";
10+
if (c.AsOdcmClass().Derived.Any() && c.AsOdcmClass().Base != null)
11+
{
12+
classDeclaration += "? extends ";
13+
}
14+
classDeclaration += TypeName(c);
15+
#>
816

917
<#=CreateClassDef(BaseTypeRequest(c), "BaseRequest", IBaseTypeRequest(c))#>
1018

1119
/**
1220
* The request for the <#=TypeName(c)#>
1321
*
14-
* @param requestUrl The request url
22+
* @param requestUrl The request URL
1523
* @param client The service client
1624
* @param requestOptions The options for this request
17-
* @param responseClass The class of the reponse
25+
* @param responseClass The class of the response
1826
*/
1927
public <#=BaseTypeRequest(c)#>(final String requestUrl,
2028
final <#=IBaseClientType()#> client,
2129
final java.util.List<? extends Option> requestOptions,
22-
final Class responseClass) {
30+
final Class<<#=classDeclaration#>> responseClass) {
2331
super(requestUrl, client, requestOptions, responseClass);
2432
}
2533

Templates/Java/requests_generated/BaseStreamRequest.java.tt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,16 @@ import java.io.*;
1313
/**
1414
* The request for this <#=TypeName(c)#>
1515
*
16-
* @param requestUrl The request url
16+
* @param requestUrl The request URL
1717
* @param client The service client
1818
* @param requestOptions The options for this request
19-
* @param responseClass The class of the reponse
19+
* @param responseClass The class of the response
2020
*/
2121
public <#=BaseTypeStreamRequest(c)#>(
2222
final String requestUrl,
2323
final <#=IBaseClientType()#> client,
2424
final java.util.List<? extends Option> requestOptions,
25-
final Class responseClass) {
25+
final Class<<#=ClassTypeName(c)#>> responseClass) {
2626
super(requestUrl, client, requestOptions, responseClass);
2727
}
2828

0 commit comments

Comments
 (0)