Skip to content

Commit a4c5796

Browse files
authored
Merge pull request #139 from microsoftgraph/java-memory-fix
Java template fix to reduce memory footprint - continued
2 parents 274e9dd + 8f821d8 commit a4c5796

File tree

4 files changed

+72
-6
lines changed

4 files changed

+72
-6
lines changed

Templates/Java/BaseJavaModel.template.tt

Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -591,6 +591,56 @@
591591
return sb.ToString();
592592
}
593593

594+
public string CreatePackageDefForIBaseMethodRequest(CustomT4Host host)
595+
{
596+
var sb = new StringBuilder();
597+
sb.Append(CreatePackageDefinition(host));
598+
var importFormat = @"import {0}.{1}.{2};";
599+
600+
var returnType = ReturnType(host.CurrentType);
601+
if(returnType != "Void" && !(host.CurrentType.AsOdcmMethod().ReturnType is OdcmPrimitiveType))
602+
{
603+
sb.AppendFormat(importFormat,
604+
host.CurrentModel.NamespaceName(),
605+
"models.extensions",
606+
ReturnType(host.CurrentType));
607+
sb.Append("\n");
608+
}
609+
610+
sb.AppendFormat(importFormat,
611+
host.CurrentModel.NamespaceName(),
612+
"requests.extensions",
613+
ITypeRequest(host.CurrentType));
614+
sb.Append("\n");
615+
return sb.ToString();
616+
}
617+
618+
public string CreatePackageDefForIBaseEntityRequest(CustomT4Host host)
619+
{
620+
var sb = new StringBuilder();
621+
sb.Append(CreatePackageDefinition(host));
622+
var importFormat = @"import {0}.{1}.{2};";
623+
sb.AppendFormat(importFormat,
624+
host.CurrentModel.NamespaceName(),
625+
"models.extensions",
626+
TypeName(host.CurrentType.AsOdcmClass()));
627+
sb.Append("\n");
628+
return sb.ToString();
629+
}
630+
631+
public string CreatePackageDefForBaseMethodRequest(CustomT4Host host)
632+
{
633+
var sb = new StringBuilder();
634+
sb.Append(CreatePackageDefForIBaseMethodRequest(host));
635+
var importFormat = @"import {0}.{1}.{2};";
636+
sb.AppendFormat(importFormat,
637+
host.CurrentModel.NamespaceName(),
638+
"requests.extensions",
639+
TypeRequest(host.CurrentType));
640+
sb.Append("\n");
641+
return sb.ToString();
642+
}
643+
594644
public string CreatePackageDefForBaseMethodRequestBuilder(CustomT4Host host)
595645
{
596646
var sb = new StringBuilder();

Templates/Java/requests_generated/BaseMethodRequest.java.tt

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,15 @@
44
<#@ output extension="\\" #>
55
<#host.TemplateName = BaseTypeRequest(c);#>
66
<#=writer.WriteHeader()#>
7-
<#=CreatePackageDef(host)#>
7+
<#=CreatePackageDefForBaseMethodRequest(host)#>
8+
import com.microsoft.graph.concurrency.ICallback;
9+
import com.microsoft.graph.concurrency.IExecutors;
10+
import com.microsoft.graph.core.ClientException;
11+
import com.microsoft.graph.core.IBaseClient;
12+
import com.microsoft.graph.http.BaseRequest;
13+
import com.microsoft.graph.http.HttpMethod;
14+
import com.microsoft.graph.options.Option;
15+
import com.microsoft.graph.options.QueryOption;
816

917
<#=CreateClassDef(BaseTypeRequest(c), "BaseRequest", IBaseTypeRequest(c))#>
1018

Templates/Java/requests_generated/IBaseEntityRequest.java.tt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,10 @@
44
<#@ output extension="\\" #>
55
<#host.TemplateName = IBaseTypeRequest(c);#>
66
<#=writer.WriteHeader()#>
7-
<#=CreatePackageDef(host)#>
7+
<#=CreatePackageDefForIBaseEntityRequest(host)#>
8+
import com.microsoft.graph.concurrency.ICallback;
9+
import com.microsoft.graph.core.ClientException;
10+
import com.microsoft.graph.http.IHttpRequest;
811

912
<#=CreateInterfaceDef(IBaseTypeRequest(c), "IHttpRequest")#>
1013

Templates/Java/requests_generated/IBaseMethodRequest.java.tt

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,15 @@
44
<#@ output extension="\\" #>
55
<#host.TemplateName = IBaseTypeRequest(c);#>
66
<#=writer.WriteHeader()#>
7-
<#=CreatePackageDef(host)#>
8-
9-
import com.google.gson.JsonObject;
10-
import com.google.gson.annotations.*;
7+
<#=CreatePackageDefForIBaseMethodRequest(host)#>
8+
import com.microsoft.graph.concurrency.ICallback;
9+
import com.microsoft.graph.concurrency.IExecutors;
10+
import com.microsoft.graph.core.ClientException;
11+
import com.microsoft.graph.core.IBaseClient;
12+
import com.microsoft.graph.http.BaseRequest;
13+
import com.microsoft.graph.http.HttpMethod;
14+
import com.microsoft.graph.options.Option;
15+
import com.microsoft.graph.options.QueryOption;
1116

1217
<#=CreateInterfaceDef(IBaseTypeRequest(c))#>
1318

0 commit comments

Comments
 (0)