Merge pull request #109 from microsoftgraph/dev_updateMethodRequest

Dev update method request

Author: MIchaelMainer

Templates/CSharp/Model/MethodRequestBody.cs.tt

@@ -7,11 +7,10 @@ var method = host.CurrentType.AsOdcmMethod();
 var entityName = method.Class.Name.ToCheckedCase();
 var requestBody = entityName + method.Name.Substring(method.Name.IndexOf('.') + 1).ToCheckedCase() + "RequestBody";
 
-// These types of request bodies are only used for OData actions, which when containing parameters,
-// will always result in POST calls. The OData spec is explicit in saying that overload methods bound
-// to other types are explicitly not allowed. Therefore, any overload methods found here are invalid
-// and violate the spec.
-System.Diagnostics.Debug.Assert(!method.Overloads.Any(), "Overload actions are not allowed in OData services");
+// Commenting this out as 12.1.1.1, Action Overload Rules, states "Bound actions support overloading (multiple 
+// actions having the same name within the same namespace) by binding parameter type. The combination of action 
+// name and the binding parameter type MUST be unique within a namespace."
+// System.Diagnostics.Debug.Assert(!method.Overloads.Any(), "Overload actions are not allowed in OData services");
 
 var attributeStringBuilder = new StringBuilder();
 attributeStringBuilder.Append("[JsonObject(MemberSerialization = MemberSerialization.OptIn)]");

Templates/CSharp/Requests/MethodRequest.cs.tt

@@ -298,7 +298,7 @@ namespace <#=method.Namespace.GetNamespaceName()#>
         /// </summary>
         /// <param name="<#=returnEntityParameter#>">The <#=returnEntityType#> object set with the properties to update.</param>
         /// <returns>The task to await for async call.</returns>
-        public <#=methodReturnType#> PatchAsync(<#=returnEntityType#> <#=returnEntityParameter#>)
+        public <#=methodOverloadReturnType#> PatchAsync(<#=returnEntityType#> <#=returnEntityParameter#>)
         {
             return this.PatchAsync(<#=returnEntityParameter#>, CancellationToken.None);
         }
@@ -399,7 +399,7 @@ namespace <#=method.Namespace.GetNamespaceName()#>
         /// </summary>
         /// <param name="<#=returnEntityParameter#>">The <#=returnEntityType#> object to update.</param>
         /// <returns>The task to await for async call.</returns>
-        public <#=methodReturnType#> PutAsync(<#=returnEntityType#> <#=returnEntityParameter#>)
+        public <#=methodOverloadReturnType#> PutAsync(<#=returnEntityType#> <#=returnEntityParameter#>)
         {
             return this.PutAsync(<#=returnEntityParameter#>, CancellationToken.None);
         }

Templates/CSharp/Requests/MethodRequestBuilder.cs.tt

@@ -14,7 +14,16 @@ var methodType = method.IsFunction ? "Function" : "Action";
 
 var overloads = new List<OdcmMethod>();
 overloads.Add(method);
-overloads.AddRange(method.Overloads);
+
+// So far, it appears that the overloads on the functions are working as expected. 
+// The overloads on actions should be skipped. If we see more issues here, we may need to
+// revisit how VIPR determines overloaded methods. 
+if (method.IsFunction)
+{
+	overloads.AddRange(method.Overloads);
+}
+
+
 
 var methods = overloads
     .Select(m =>
@@ -66,7 +75,9 @@ namespace <#=method.Namespace.GetNamespaceName()#>
     {
 <#
 foreach (var m in methods)
+
 {
+
 #>
         /// <summary>
         /// Constructs a new <see cref="<#=requestBuilderType#>"/>.