Skip to content

Commit be48299

Browse files
committed
This change removes the duplicate cstor on SynchronizationJobValidateCredentialsRequestBuilder. While the ValidateCredentials action is overloaded, we don't handle this scenario here. There is a collection request builder for jobs where the validateCreentials action is called.
1 parent 9309fcf commit be48299

File tree

1 file changed

+12
-1
lines changed

1 file changed

+12
-1
lines changed

Templates/CSharp/Requests/MethodRequestBuilder.cs.tt

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,16 @@ var methodType = method.IsFunction ? "Function" : "Action";
1414

1515
var overloads = new List<OdcmMethod>();
1616
overloads.Add(method);
17-
overloads.AddRange(method.Overloads);
17+
18+
// So far, it appears that the overloads on the functions are working as expected.
19+
// The overloads on actions should be skipped. If we see more issues here, we may need to
20+
// revisit how VIPR determines overloaded methods.
21+
if (method.IsFunction)
22+
{
23+
overloads.AddRange(method.Overloads);
24+
}
25+
26+
1827

1928
var methods = overloads
2029
.Select(m =>
@@ -66,7 +75,9 @@ namespace <#=method.Namespace.GetNamespaceName()#>
6675
{
6776
<#
6877
foreach (var m in methods)
78+
6979
{
80+
7081
#>
7182
/// <summary>
7283
/// Constructs a new <see cref="<#=requestBuilderType#>"/>.

0 commit comments

Comments
 (0)