Add logging for reserved word translation

Author: Caitlin Bales (MSFT)

src/GraphODataTemplateWriter/.config/TemplateWriterSettings.json

@@ -1,4 +1,4 @@
-{
+{
     "AvailableLanguages": [ "Android", "ObjC", "CSharp", "PHP", "Python", "TypeScript", "GraphEndpointList" ],
     "TargetLanguage": "CSharp",
     "Plugins": [ ],

src/GraphODataTemplateWriter/CodeHelpers/Android/TypeHelperAndroid.cs

@@ -97,7 +97,7 @@ public static string SanitizePropertyName(this string property, OdcmObject odcmP
         {
             if (ReservedNames.Contains(property))
             {
-                logger.Info("Property {0} is a reserved word in Android. Converting to {1}{0}", property, ReservedPrefix);
+                logger.Info("Property \"{0}\" is a reserved word in Android. Converting to \"{1}{0}\"", property, ReservedPrefix);
                 return ReservedPrefix + property;
             }
 
@@ -107,7 +107,7 @@ public static string SanitizePropertyName(this string property, OdcmObject odcmP
                 if (odcmProperty.Projection.Type.Name.ToUpperFirstChar() == odcmProperty.Name.ToUpperFirstChar())
                 {
                     // Name the property: {metadataName} + "Property"
-                    logger.Info("Property type {0} has the same name as the class. Converting to {0}Property", property);
+                    logger.Info("Property type \"{0}\" has the same name as the class. Converting to \"{0}Property\"", property);
                     return string.Concat(property, "Property");
                 }
 

src/GraphODataTemplateWriter/CodeHelpers/CSharp/TypeHelperCSharp.cs

@@ -238,7 +238,7 @@ public static string GetSanitizedPropertyName(this string property, OdcmProperty
             {
                 var reservedPrefix = string.IsNullOrEmpty(prefix) ? DefaultReservedPrefix : prefix;
 
-                logger.Info("Property {0} is a reserved word in .NET. Converting to {1}{0}", property.ToUpperFirstChar(), reservedPrefix);
+                logger.Info("Property \"{0}\" is a reserved word in .NET. Converting to \"{1}{0}\"", property.ToUpperFirstChar(), reservedPrefix);
                 return string.Concat(reservedPrefix, property.ToUpperFirstChar());
             }
 
@@ -251,7 +251,7 @@ public static string GetSanitizedPropertyName(this string property, OdcmProperty
                 if (odcmProperty.Projection.Type.Name.ToUpperFirstChar() == odcmProperty.Class.Name.ToUpperFirstChar())
                 {
                     // Name the property: {metadataName} + "Property"
-                    logger.Info("Property type {0} has the same name as the class. Converting to {0}Property", property);
+                    logger.Info("Property type \"{0}\" has the same name as the class. Converting to \"{0}Property\"", property);
                     return string.Concat(property, "Property");
                 }
 

src/GraphODataTemplateWriter/CodeHelpers/ObjC/TypeHelperObjC.cs

@@ -7,11 +7,14 @@ namespace Microsoft.Graph.ODataTemplateWriter.CodeHelpers.ObjC
     using Microsoft.Graph.ODataTemplateWriter.Extensions;
     using Microsoft.Graph.ODataTemplateWriter.Settings;
     using Vipr.Core.CodeModel;
+    using NLog;
 
     public static class TypeHelperObjC
     {
         public static string Prefix = ConfigurationService.Settings.NamespacePrefix;
 
+        private static Logger logger = LogManager.GetCurrentClassLogger();
+
         private static ICollection<string> reservedNames;
         public static ICollection<string> ReservedNames
         {
@@ -157,6 +160,10 @@ public static string SanitizePropertyName(this OdcmProperty property)
         {
             if (ReservedNames.Contains(property.Name.ToLower()))
             {
+                logger.Info("Property \"{0}\" is a reserved word in Objective-C. Converting to \"{1}{0}\"", 
+                    property.Name.ToUpperFirstChar(), 
+                    property.Class.Name.ToLowerFirstChar()
+                );
                 return property.Class.Name.ToLowerFirstChar() + property.Name.ToUpperFirstChar();
             }
             return property.Name;

src/GraphODataTemplateWriter/CodeHelpers/PHP/TypeHelperPHP.cs

@@ -6,10 +6,13 @@ namespace Microsoft.Graph.ODataTemplateWriter.CodeHelpers.PHP
     using Microsoft.Graph.ODataTemplateWriter.Extensions;
     using Vipr.Core.CodeModel;
     using System;
+    using NLog;
 
     public static class TypeHelperPHP
     {
         public const string ReservedPrefix = "Graph";
+        private static Logger logger = LogManager.GetCurrentClassLogger();
+
         public static HashSet<string> ReservedNames
         {
             get
@@ -120,6 +123,7 @@ public static string SanitizeEntityName(this String name)
         {
             if (ReservedNames.Contains(name))
             {
+                logger.Info("Property \"{0}\" is a reserved word in PHP. Converting to \"{1}{0}\"", name, ReservedPrefix);
                 return ReservedPrefix + name.ToCheckedCase();
             }
 
@@ -130,6 +134,7 @@ public static string SanitizePropertyName(this String name, String entityName)
         {
             if (name == "properties")
             {
+                logger.Info("Property \"{0}\" is a reserved word in PHP. Converting to \"{1}{0}\"", name, ReservedPrefix);
                 return entityName + name.ToCheckedCase();
             }
 

src/GraphODataTemplateWriter/CodeHelpers/Python/TypeHelperPython.cs

@@ -5,10 +5,13 @@ namespace Microsoft.Graph.ODataTemplateWriter.CodeHelpers.Python
     using System.Collections.Generic;
     using Microsoft.Graph.ODataTemplateWriter.Extensions;
     using Vipr.Core.CodeModel;
+    using NLog;
 
     public static class TypeHelperPython
     {
         public const string ReservedPrefix = "$$__$$";
+        private static Logger logger = LogManager.GetCurrentClassLogger();
+
         public static ICollection<string> ReservedNames
         {
             get
@@ -102,6 +105,7 @@ public static string GetToLowerFirstCharName(this OdcmProperty property)
         public static string SanitizePropertyName(this OdcmProperty property)
         {
             if (ReservedNames.Contains(property.Name.ToLower())) {
+                logger.Info("Property \"{0}\" is a reserved word in Python. Converting to \"{1}{0}\"", property.Name, ReservedPrefix);
                 return ReservedPrefix + property.Name;
             }
             return property.Name;