Skip to content

Commit fab1735

Browse files
author
Caitlin Bales (MSFT)
committed
Fix Content name collision in Android
1 parent 3a0ba5e commit fab1735

File tree

3 files changed

+13
-2
lines changed

3 files changed

+13
-2
lines changed

Templates/Android/generated/BaseEntityRequestBuilder.java.tt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,9 @@ if (c.AsOdcmClass() != null)
7979
foreach (var prop in c.AsOdcmClass().GetProperties(typeName:"Stream"))
8080
{
8181
var propName = prop.Name.ToCheckedCase();
82+
if (c is OdcmMediaClass && propName == "Content") {
83+
propName = prop.Type.GetReservedPrefix().ToCheckedCase() + prop.Name.ToCheckedCase();
84+
}
8285
var propRequestBuilder = TypeRequestBuilder(prop);
8386
#>
8487

Templates/Android/generated/IBaseEntityRequestBuilder.java.tt

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,11 @@ if (c.AsOdcmClass() != null)
5454
<#
5555
foreach (var prop in c.AsOdcmClass().GetProperties(typeName:"Stream"))
5656
{
57-
var propName = prop.Name.ToCheckedCase();
57+
var propName = prop.Name.ToCheckedCase();
58+
if (c is OdcmMediaClass && propName == "Content") {
59+
propName = prop.Type.GetReservedPrefix().ToCheckedCase() + prop.Name.ToCheckedCase();
60+
}
61+
5862
var propRequestBuilder = TypeRequestBuilder(prop);
5963
#>
6064

@@ -73,7 +77,6 @@ if (c.AsOdcmClass() != null)
7377
#>
7478
<#
7579
foreach (var method in c.AsOdcmClass().MethodsAndOverloads()) {
76-
7780
if (method.IsBoundToCollection) {
7881
continue;
7982
}

src/GraphODataTemplateWriter/CodeHelpers/Android/TypeHelperAndroid.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,11 @@ public static HashSet<string> ReservedNames
2020
}
2121
}
2222

23+
public static string GetReservedPrefix(this OdcmType @type)
24+
{
25+
return ReservedPrefix;
26+
}
27+
2328
public static string GetTypeString(this OdcmType @type)
2429
{
2530
switch (@type.Name)

0 commit comments

Comments
 (0)