Skip to content

Commit fb841ba

Browse files
committed
ci: clarify use of version when creating PR
1 parent 1766791 commit fb841ba

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

.azure-pipelines/generation-templates/capture-openapi.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -185,5 +185,6 @@ jobs:
185185
OverrideSkipCI: false
186186
RepoName: 'microsoftgraph/msgraph-metadata'
187187
ScriptsDirectory: $(scriptsDirectory)
188+
# Version is intentionally left empty for OpenAPI PRs as versioning is not applicable in this context.
188189
Version: ''
189190
workingDirectory: '$(Build.SourcesDirectory)/msgraph-metadata'

scripts/create-pull-request.ps1

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,17 @@ if (($env:GeneratePullRequest -eq $False)) { # Skip CI if manually running this
1111

1212
$version = $env:Version
1313

14-
# Special case for beta typings as it uses a non-conforming preview versioning.
15-
if ($env:RepoName.Contains("msgraph-beta-typescript-typings"))
14+
if ($version -ne '')
1615
{
17-
$title = "feat: generated $version models and request builders"
16+
# Special case for beta typings as it uses a non-conforming preview versioning. Helps with triggering Release Please.
17+
if ($env:RepoName.Contains("msgraph-beta-typescript-typings"))
18+
{
19+
$title = "feat: generated $version models and request builders"
20+
}
21+
else {
22+
$title = "Generated $version models and request builders"
23+
}
1824
}
19-
else {
20-
$title = "Generated $version models and request builders"
21-
}
22-
2325
$body = ":bangbang:**_Important_**:bangbang: <br> Check for unexpected deletions or changes in this PR and ensure relevant CI checks are passing. <br><br> **Note:** This pull request was automatically created by Azure pipelines."
2426
$baseBranchParameter = ""
2527

0 commit comments

Comments
 (0)