Skip to content

Commit 505bd2e

Browse files
authored
Merge branch 'dev' into fix/resizable-component
2 parents 53dd2b7 + 48b35b0 commit 505bd2e

File tree

17 files changed

+137
-63
lines changed

17 files changed

+137
-63
lines changed

.github/policies/resourceManagement.yml

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,6 @@ configuration:
8989
- isOpen
9090
- not:
9191
and:
92-
- isAssignedToSomeone
9392
- isLabeled
9493
then:
9594
- addLabel:
@@ -98,7 +97,17 @@ configuration:
9897
- payloadType: Issues
9998
- and:
10099
- isOpen
101-
- isAssignedToSomeone
100+
- isLabeled
101+
- not:
102+
and:
103+
- isAssignedToSomeone
104+
then:
105+
- addLabel:
106+
label: 'Triaged-Unassigned'
107+
- if:
108+
- payloadType: Issues
109+
- and:
110+
- isOpen
102111
- isLabeled
103112
then:
104113
- removeLabel:

src/app/services/actions/autocomplete-action-creators.spec.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,8 @@ const mockState: ApplicationState = {
4747
samples: {
4848
queries: [],
4949
pending: false,
50-
error: null
50+
error: null,
51+
hasAutoSelectedDefault: false
5152
},
5253
scopes: {
5354
pending: { isSpecificPermissions: false, isFullPermissions: false },
@@ -123,7 +124,8 @@ store.getState = () => ({
123124
samples: {
124125
queries: [],
125126
pending: false,
126-
error: null
127+
error: null,
128+
hasAutoSelectedDefault: false
127129
}
128130
})
129131

src/app/services/actions/permissions-action-creator.spec.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,8 @@ const mockState: ApplicationState = {
6868
samples: {
6969
queries: [],
7070
pending: false,
71-
error: null
71+
error: null,
72+
hasAutoSelectedDefault: false
7273
},
7374
scopes: {
7475
pending: { isSpecificPermissions: false, isFullPermissions: false },

src/app/services/actions/resource-explorer-action-creators.spec.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,8 @@ const mockState: ApplicationState = {
4343
samples: {
4444
queries: [],
4545
pending: false,
46-
error: null
46+
error: null,
47+
hasAutoSelectedDefault: false
4748
},
4849
permissionGrants: {
4950
permissions: [],

src/app/services/slices/samples.slice.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,14 @@ interface SamplesState {
99
queries: ISampleQuery[];
1010
pending: boolean;
1111
error: object | null | string;
12+
hasAutoSelectedDefault: boolean;
1213
}
1314

1415
const initialState: SamplesState = {
1516
queries: [],
1617
pending: false,
17-
error: null
18+
error: null,
19+
hasAutoSelectedDefault: false
1820
};
1921

2022
export const fetchSamples = createAsyncThunk<ISampleQuery[], void, { rejectValue: ISampleQuery[] }>(
@@ -52,7 +54,11 @@ export const fetchSamples = createAsyncThunk<ISampleQuery[], void, { rejectValue
5254
const samplesSlice = createSlice({
5355
name: 'samples',
5456
initialState,
55-
reducers: {},
57+
reducers: {
58+
setHasAutoSelectedDefault: (state, action) => {
59+
state.hasAutoSelectedDefault = action.payload;
60+
}
61+
},
5662
extraReducers: (builder) => {
5763
builder
5864
.addCase(fetchSamples.pending, (state) => {
@@ -73,4 +79,5 @@ const samplesSlice = createSlice({
7379
}
7480
});
7581

82+
export const { setHasAutoSelectedDefault } = samplesSlice.actions;
7683
export default samplesSlice.reducer;

src/app/views/App.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import {
22
FluentProvider,
3-
teamsHighContrastTheme,
43
Theme,
54
webDarkTheme,
65
webLightTheme
@@ -256,8 +255,7 @@ class App extends Component<IAppProps, IAppState> {
256255
public render() {
257256
const fluentV9Themes: Record<string, Theme> = {
258257
light: webLightTheme,
259-
dark: webDarkTheme,
260-
'high-contrast': teamsHighContrastTheme
258+
dark: webDarkTheme
261259
};
262260
return (
263261
<FluentProvider theme={fluentV9Themes[this.props.appTheme]}>

src/app/views/main-header/settings/ThemeChooser.tsx

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { PopupsComponent } from '../../../services/context/popups-context';
66
import { changeTheme } from '../../../services/slices/theme.slice';
77
import { translateMessage } from '../../../utils/translate-messages';
88
import { useIconOptionStyles, useRadioGroupStyles } from './ThemeChooser.styles';
9-
import { BrightnessHigh24Regular, WeatherMoon24Regular, DarkTheme24Regular} from '@fluentui/react-icons';
9+
import { BrightnessHigh24Regular, WeatherMoon24Regular} from '@fluentui/react-icons';
1010

1111
const availableThemes = [
1212
{
@@ -18,11 +18,6 @@ const availableThemes = [
1818
key: 'dark',
1919
displayName: 'Dark',
2020
icon: <WeatherMoon24Regular />
21-
},
22-
{
23-
key: 'high-contrast',
24-
displayName: 'High Contrast',
25-
icon: <DarkTheme24Regular />
2621
}
2722
];
2823

src/app/views/sidebar/Sidebar.styles.tsx

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,15 @@ export const useSidebarStyles = makeStyles({
2929
maxWidth: '100%'
3030
},
3131
activeLeaf: {
32-
backgroundColor: tokens.colorNeutralBackground3Hover
32+
backgroundColor: tokens.colorNeutralBackground3Hover,
33+
'@media (forced-colors: active)': {
34+
backgroundColor: 'Highlight',
35+
color: 'HighlightText',
36+
forcedColorAdjust: 'none',
37+
// Adding border for better visibility in high contrast mode
38+
outlineWidth: '2px',
39+
outlineStyle: 'solid',
40+
outlineColor: 'ButtonText'
41+
}
3342
}
3443
})

src/app/views/sidebar/history/History.styles.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@ export const useHistoryStyles = makeStyles({
99
alignItems: 'center',
1010
gap: '2px'
1111
},
12+
button: {
13+
border: 'none'
14+
},
1215
badgeContainer: {
1316
minWidth: '50px',
1417
display: 'inline-flex'

src/app/views/sidebar/history/History.tsx

Lines changed: 20 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,9 @@ import {
3434
} from '@fluentui/react-components';
3535
import {
3636
AddSquare20Regular,
37-
ArrowDownloadRegular,
38-
DeleteRegular,
39-
MoreHorizontalRegular,
37+
ArrowDownload20Regular,
38+
Delete20Regular,
39+
MoreHorizontal20Regular,
4040
SubtractSquare20Regular
4141
} from '@fluentui/react-icons';
4242
import React, { useEffect, useRef, useState } from 'react';
@@ -143,14 +143,15 @@ const GroupIcons = (props: AsideGroupIconsProps)=>{
143143
<Tooltip withArrow relationship="label" content={`${translateMessage('Export')} ${groupName} queries`}>
144144
<Button onClick={
145145
(e) => handleDownloadHistoryGroup(e,groupName, historyItems )}
146-
appearance="subtle" icon={<ArrowDownloadRegular/>}></Button>
146+
appearance="subtle" icon={<ArrowDownload20Regular/>} className={styles.button}></Button>
147147
</Tooltip>
148148
<Dialog open={open} onOpenChange={(_event, data) => setOpen(data.open)}>
149149
<DialogTrigger disableButtonEnhancement>
150150
<Tooltip withArrow relationship="label" content={`${translateMessage('Delete')} ${groupName} queries`}>
151151
<Button
152152
appearance="subtle"
153-
icon={<DeleteRegular/>}
153+
icon={<Delete20Regular/>}
154+
className={styles.button}
154155
onClick={(e) => {
155156
e.stopPropagation();
156157
setOpen(true);
@@ -198,6 +199,7 @@ interface HistoryProps {
198199
const HistoryItems = (props: HistoryProps)=>{
199200
const dispatch = useAppDispatch();
200201
const sidebarStyles = useSidebarStyles();
202+
const historyStyles = useHistoryStyles();
201203
const {groups, history} = props
202204
const shouldGenerateGroups = useRef(true);
203205
const [selectedItemKey, setSelectedItemKey] = useState<string | null>(null);
@@ -348,6 +350,7 @@ const HistoryItems = (props: HistoryProps)=>{
348350
aria-label={translateMessage('Remove from collection')}
349351
appearance='transparent'
350352
icon={<SubtractSquare20Regular />}
353+
className={historyStyles.button}
351354
onClick={ (e: React.MouseEvent<HTMLButtonElement>) => {
352355
e.stopPropagation();
353356
handleRemoveFromCollection(h);
@@ -365,6 +368,7 @@ const HistoryItems = (props: HistoryProps)=>{
365368
aria-label={translateMessage('Add to collection')}
366369
appearance='transparent'
367370
icon={<AddSquare20Regular />}
371+
className={historyStyles.button}
368372
onClick={(e: React.MouseEvent<HTMLButtonElement>) => {
369373
e.stopPropagation();
370374
handleAddToCollection(h);
@@ -432,6 +436,7 @@ interface HistoryItemActionMenuProps {
432436

433437
const HistoryItemActionMenu = (props: HistoryItemActionMenuProps)=>{
434438
const dispatch = useAppDispatch()
439+
const historyStyles = useHistoryStyles()
435440
const {item} = props
436441

437442
const handleExportQuery = (query: IHistoryItem)=>{
@@ -457,21 +462,28 @@ const HistoryItemActionMenu = (props: HistoryItemActionMenuProps)=>{
457462
}
458463
return <Menu>
459464
<MenuTrigger disableButtonEnhancement>
460-
<Button tabIndex={0} appearance='subtle' icon={<MoreHorizontalRegular/>}></Button>
465+
<Button
466+
tabIndex={0}
467+
appearance='subtle'
468+
icon={<MoreHorizontal20Regular />}
469+
className={historyStyles.button}
470+
></Button>
461471
</MenuTrigger>
462472

463473
<MenuPopover>
464474
<MenuList>
465475
<MenuGroup>
466476
<MenuGroupHeader>{translateMessage('actions')}</MenuGroupHeader>
467-
<MenuItem icon={<ArrowDownloadRegular/>}
477+
<MenuItem icon={<ArrowDownload20Regular/>}
478+
className={historyStyles.button}
468479
onClick={(e) => {
469480
e.stopPropagation();
470481
handleExportQuery(item);
471482
}}>
472483
{translateMessage('Export')}
473484
</MenuItem>
474-
<MenuItem icon={<DeleteRegular/>}
485+
<MenuItem icon={<Delete20Regular/>}
486+
className={historyStyles.button}
475487
onClick={(e) => {
476488
e.stopPropagation();
477489
handleDeleteQuery(item);

0 commit comments

Comments
 (0)