Skip to content

Commit 0f68f60

Browse files
authored
fix: resolving storybook a11y issues (#2129)
fixed contrast of html attributes in monaco editor fixed contrast of numeric css values in monaco editor added underline to anchor tags in preview frame
1 parent cfeceeb commit 0f68f60

File tree

4 files changed

+17
-4
lines changed

4 files changed

+17
-4
lines changed

.storybook/preview-body.html

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,14 +80,21 @@
8080
color: #0360B9 !important;
8181
}
8282

83-
.css-zj0253 * .token.attr-name {
83+
/* fix attributes in html rendering */
84+
.mtk4, .css-zj0253 * .token.attr-name {
8485
color: #e50000 !important;
8586
}
8687

88+
/* fix number colors in monaco editor */
89+
.mtk7 {
90+
color: #088155 !important;
91+
}
92+
8793
.css-3ltsna:focus-visible {
8894
outline: auto;
8995
}
9096

97+
9198
@media (max-width: 768px) {
9299
.story-mgt-root {
93100
flex-direction: column;

.storybook/preview-head.html

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,8 @@
1010
};
1111
awa.init(config);
1212
</script>
13+
<style>
14+
a {
15+
text-decoration: underline !important;
16+
}
17+
</style>

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,8 @@
9393
"jest-junit": "^6.3.0",
9494
"lerna": "^3.22.1",
9595
"lit-element": "2.5.0",
96-
"monaco-editor": "^0.19.3",
97-
"monaco-editor-webpack-plugin": "^1.8.2",
96+
"monaco-editor": "^0.30.0",
97+
"monaco-editor-webpack-plugin": "^6.0.0",
9898
"node-sass": "npm:sass@^1.44.0",
9999
"npm-run-all": "^4.1.5",
100100
"prettier": "2.2.1",

packages/mgt-element/src/utils/GraphHelpers.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66
*/
77

88
import { AuthenticationHandlerOptions, Middleware } from '@microsoft/microsoft-graph-client';
9-
import { GraphEndpoint, MICROSOFT_GRAPH_ENDPOINTS, Providers } from '..';
9+
import { Providers } from '../providers/Providers';
10+
import { GraphEndpoint, MICROSOFT_GRAPH_ENDPOINTS } from '../IGraph';
1011

1112
/**
1213
* creates an AuthenticationHandlerOptions from scopes array that

0 commit comments

Comments
 (0)