Skip to content

Commit 239afd5

Browse files
beth-panxnmetulev
andauthored
mgt-people-picker patch (#823)
* Fix people picker height jump as select/de-select person * Fix firefox flyout bug * Add spacing for people picker Co-authored-by: Nikola Metulev <[email protected]>
1 parent cc139cb commit 239afd5

File tree

2 files changed

+28
-27
lines changed

2 files changed

+28
-27
lines changed

.storybook/addons/codeEditorAddon/codeAddon.js

Lines changed: 22 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -104,25 +104,28 @@ export const withCodeEditor = makeDecorator({
104104
);
105105

106106
const docContent = `
107-
<html>
108-
<head>
109-
<script type="module" src="${mgtScriptName}"></script>
110-
<script type="module">
111-
import {Providers, MockProvider} from "${mgtScriptName}";
112-
Providers.globalProvider = new MockProvider(true);
113-
</script>
114-
<style>
115-
${css}
116-
</style>
117-
</head>
118-
<body>
119-
${html}
120-
<script type="module">
121-
${js}
122-
</script>
123-
</body>
124-
</html>
125-
`;
107+
<html>
108+
<head>
109+
<script type="module" src="${mgtScriptName}"></script>
110+
<script type="module">
111+
import {Providers, MockProvider} from "${mgtScriptName}";
112+
Providers.globalProvider = new MockProvider(true);
113+
</script>
114+
<style>
115+
html, body {
116+
height: 100%;
117+
}
118+
${css}
119+
</style>
120+
</head>
121+
<body>
122+
${html}
123+
<script type="module">
124+
${js}
125+
</script>
126+
</body>
127+
</html>
128+
`;
126129

127130
doc.open();
128131
doc.write(docContent);

packages/mgt-components/src/components/mgt-people-picker/mgt-people-picker.scss

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -33,23 +33,22 @@ mgt-people-picker .root {
3333
&.focused {
3434
border-color: $input__border-color--focus;
3535
}
36-
padding-bottom: 6px;
36+
padding: 6px 0 0;
3737

3838
.selected-list {
3939
flex: 1 0 auto;
4040
display: flex;
4141
flex-wrap: wrap;
4242
vertical-align: middle;
43-
margin: 0 2px 0 0;
43+
margin: 0 8px;
4444
list-style-type: none;
45-
padding-left: 8px;
4645
font-style: normal;
4746
font-weight: normal;
4847
overflow: hidden;
4948

5049
&__person-wrapper {
5150
display: flex;
52-
margin: 5px 5px 0px 0;
51+
margin: 0 5px 6px 0;
5352
align-items: center;
5453
border-radius: 15px;
5554
height: 24px;
@@ -66,8 +65,8 @@ mgt-people-picker .root {
6665
margin-left: 0px;
6766
--color: #{$color};
6867
color: $color;
69-
margin-bottom: 1px;
70-
margin-right: 4px;
68+
padding-bottom: 1px;
69+
padding-right: 4px;
7170
}
7271

7372
&__overflow {
@@ -103,10 +102,9 @@ mgt-people-picker .root {
103102

104103
.flyout {
105104
.search-box {
106-
margin: 6px 2px 1px 3px;
105+
margin: 1px 2px 8px;
107106

108107
&.search-box-start {
109-
margin: 6px 0px 1px 0px;
110108
line-height: normal;
111109
margin-inline-start: 0px;
112110
margin-inline-end: 0px;

0 commit comments

Comments
 (0)