fix: check the options scopes are not empty when getting access token (#3256)

* Check the options scopes are not empty when getting access token

* Update the node version to 18+ for devcontainers

* Address prettier complaints

* Update packages/providers/mgt-msal2-provider/src/Msal2Provider.ts

Co-authored-by: Nickii Miaro <[email protected]>

---------

Co-authored-by: Nickii Miaro <[email protected]>

Author: musale

.devcontainer/devcontainer.json

@@ -1,5 +1,5 @@
 {
-  "image": "mcr.microsoft.com/devcontainers/javascript-node:0-16",
+  "image": "mcr.microsoft.com/devcontainers/javascript-node:0-18",
   "customizations": {
     "vscode": {
       "extensions": [
@@ -14,4 +14,4 @@
     }
   },
   "forwardPorts": [3000, 6006]
-}
+}

packages/providers/mgt-electron-provider/src/Authenticator/ElectronAuthenticator.ts

@@ -344,7 +344,7 @@ export class ElectronAuthenticator {
    */
   protected async getAccessToken(options?: AuthenticationProviderOptions): Promise<string | undefined> {
     let authResponse: AuthenticationResult | null = null;
-    const scopes = options?.scopes ? options.scopes : this.authCodeUrlParams.scopes;
+    const scopes = options?.scopes?.length ? options.scopes : this.authCodeUrlParams.scopes;
     const account = this.account || (await this.getAccount());
     if (account) {
       const request = {

packages/providers/mgt-msal2-provider/src/Msal2Provider.ts

@@ -733,8 +733,8 @@ export class Msal2Provider extends IProvider {
    * @return {*}  {Promise<string>}
    * @memberof Msal2Provider
    */
-  public async getAccessToken(options?: AuthenticationProviderOptions): Promise<string> {
-    const scopes = options ? options.scopes || this.scopes : this.scopes;
+  public async getAccessToken(opts?: AuthenticationProviderOptions): Promise<string> {
+    const scopes = opts?.scopes?.length ? opts.scopes : this.scopes;
     const accessTokenRequest: SilentRequest = {
       scopes,
       account: this.getAccount()