chore: fix storybook foldering (#1953)

* chore: fix storybook foldering

* fix filename

* move pipelines to node v14

* adjusting comparisons to compile

Author: gavinbarron

.github/workflows/pr.yml

@@ -13,7 +13,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [12.x, 14.x, 16.x]
+        node-version: [14.x, 16.x]
 
     steps:
       - uses: actions/checkout@v2

.github/workflows/push-release.yml

@@ -42,7 +42,7 @@ jobs:
     if: needs.version.outputs.latest-version != needs.version.outputs.package-version
     strategy:
       matrix:
-        node-version: [12.x]
+        node-version: [14.x]
 
     environment:
       name: release
@@ -80,7 +80,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [12.x]
+        node-version: [14.x]
 
     steps:
       - uses: actions/checkout@v2

.github/workflows/storybook copy.yml renamed to .github/workflows/storybook-v3.yml

@@ -36,8 +36,5 @@ jobs:
         with:
           branch: gh-pages
           folder: storybook-static
-          target-folder: fluentui
-          clean-exclude: |
-            pr
-            next
+          target-folder: next/v3
           token: ${{ secrets.GITHUB_TOKEN }}

packages/mgt-components/src/components/mgt-people-picker/mgt-people-picker.ts

@@ -1068,9 +1068,11 @@ export class MgtPeoplePicker extends MgtTemplatedComponent {
               } catch (_) {}
             } else {
               let groups = (await findGroups(graph, '', this.showMax, this.groupType, this._groupFilters)) || [];
+              // tslint:disable: no-string-literal
               if (groups.length > 0 && groups[0]['value']) {
                 groups = groups[0]['value'];
               }
+              // tslint:enable: no-string-literal
               people = groups;
             }
           }
@@ -1222,7 +1224,7 @@ export class MgtPeoplePicker extends MgtTemplatedComponent {
    */
   private async getGroupsForGroupIds(graph: IGraph, people: IDynamicPerson[]) {
     const groups = await getGroupsForGroupIds(graph, this.groupIds, this.groupFilters);
-    for (let group of groups as IDynamicPerson[]) {
+    for (const group of groups as IDynamicPerson[]) {
       people = people.concat(group);
     }
     people = people.filter(person => person);
@@ -1526,7 +1528,7 @@ export class MgtPeoplePicker extends MgtTemplatedComponent {
       if (isCmdOrCtrlKey && event.code === 'ArrowLeft') {
         this._currentHighlightedUserPos =
           (this._currentHighlightedUserPos - 1 + selectedPeople.length) % selectedPeople.length;
-        if (this._currentHighlightedUserPos >= 0 && this._currentHighlightedUserPos !== NaN) {
+        if (this._currentHighlightedUserPos >= 0 && !Number.isNaN(this._currentHighlightedUserPos)) {
           this._highlightedUsers.push(selectedPeople[this._currentHighlightedUserPos]);
         } else {
           this._currentHighlightedUserPos = 0;

packages/mgt-components/src/graph/graph.presence.ts

@@ -86,7 +86,7 @@ export async function getUsersPresenceByPeople(graph: IGraph, people?: IDynamicP
   }
 
   for (const person of people) {
-    if (person !== '' && person.id) {
+    if (person?.id) {
       const id = person.id;
       peoplePresence[id] = null;
       let presence: CachePresence;