Skip to content

Commit 4a7ea6c

Browse files
committed
fixed minor issues in ie11
1 parent 962d62a commit 4a7ea6c

File tree

4 files changed

+26
-10
lines changed

4 files changed

+26
-10
lines changed

index.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,10 @@
3232
<!-- <mgt-mock-provider></mgt-mock-provider> -->
3333

3434
<mgt-login></mgt-login>
35+
<mgt-person person-query="me" show-name show-email person-card="hover"></mgt-person>
36+
<mgt-people-picker></mgt-people-picker>
3537
<mgt-tasks data-source="todo"></mgt-tasks>
3638
<mgt-agenda group-by-day></mgt-agenda>
3739
<mgt-people></mgt-people>
38-
<mgt-people-picker></mgt-people-picker>
3940
</body>
4041
</html>

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464
"@babel/preset-typescript": "^7.3.3",
6565
"@types/jest": "^24.0.11",
6666
"@webcomponents/webcomponentsjs": "^2.2.10",
67-
"babel-polyfill": "6.26.0",
67+
"babel-polyfill": "^6.5.0",
6868
"browser-sync": "^2.26.7",
6969
"cpx": "^1.5.0",
7070
"gulp": "^4.0.0",

src/components/mgt-person-card/mgt-person-card.scss

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ $font-size: var(--font-size, #{$ms-font-size-m});
1010
$font-weight: var(--font-weight, #{$ms-font-weight-semibold});
1111
$color: var(--color, #{$ms-color-neutralDark});
1212

13-
.root {
13+
:host .root {
1414
position: relative;
1515
width: 340px;
1616
background: #ffffff;
@@ -21,7 +21,7 @@ $color: var(--color, #{$ms-color-neutralDark});
2121
display: flex;
2222
padding: 18px 14px;
2323

24-
mgt-person {
24+
mgt-person.person-image {
2525
--avatar-size-s: 75px;
2626
}
2727

@@ -53,7 +53,10 @@ $color: var(--color, #{$ms-color-neutralDark});
5353
-webkit-align-items: center;
5454
align-items: center;
5555
max-width: 120px;
56-
justify-content: space-between;
56+
57+
.icon {
58+
margin: 0 22px 0 0;
59+
}
5760
.icon:hover {
5861
opacity: 0.6;
5962
}
@@ -78,6 +81,8 @@ $color: var(--color, #{$ms-color-neutralDark});
7881
}
7982
.additional-details-info {
8083
margin: 0 0 0 20px;
84+
padding-bottom: 18px;
85+
8186
.contact-text {
8287
margin: 0 0 24px 0;
8388
font-weight: 600;

src/components/mgt-person-card/mgt-person-card.ts

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,11 @@ export class MgtPersonCard extends MgtTemplatedComponent {
121121
<div class="default-view">
122122
${this.renderTemplate('default', { person: this.personDetails }) ||
123123
html`
124-
<mgt-person .personDetails=${this.personDetails} .personImage=${this.personImage}></mgt-person>
124+
<mgt-person
125+
class="person-image"
126+
.personDetails=${this.personDetails}
127+
.personImage=${this.personImage}
128+
></mgt-person>
125129
<div class="details">
126130
<div class="display-name">${user.displayName}</div>
127131
${jobTitle} ${department}
@@ -214,6 +218,8 @@ export class MgtPersonCard extends MgtTemplatedComponent {
214218
</div>
215219
`;
216220
}
221+
const renderAdditionalSection: boolean = this.templates && this.templates['additional-details'];
222+
217223
return html`
218224
<div class="additional-details-info">
219225
<div class="contact-text">Contact</div>
@@ -222,10 +228,14 @@ export class MgtPersonCard extends MgtTemplatedComponent {
222228
<div class="icons">
223229
${chat} ${email} ${phone} ${location}
224230
</div>
225-
<div class="section-divider"></div>
226-
<div class="custom-section">
227-
${this.renderTemplate('additional-details', null)}
228-
</div>
231+
${renderAdditionalSection
232+
? html`
233+
<div class="section-divider"></div>
234+
<div class="custom-section">
235+
${this.renderTemplate('additional-details', null)}
236+
</div>
237+
`
238+
: null}
229239
</div>
230240
</div>
231241
</div>

0 commit comments

Comments
 (0)