Skip to content

Commit 59301ab

Browse files
authored
fix: announce suggestion list changes (#2148)
adds aria-live to the suggestions list to announce changes to it
1 parent 617989e commit 59301ab

File tree

4 files changed

+8
-4
lines changed

4 files changed

+8
-4
lines changed

.github/workflows/pr-storybook.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,9 @@ jobs:
2727

2828
- name: Install deps 🛠
2929
run: |
30-
npm install -g yarn lerna
30+
echo "installing yarn"
31+
npm install -g yarn
32+
echo "installing deps for packages"
3133
yarn
3234
- name: Extract tag name
3335
shell: bash

.github/workflows/storybook.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626

2727
- name: Build 🛠
2828
run: |
29-
npm install -g yarn lerna
29+
npm install -g yarn lerna@6.4.1
3030
yarn
3131
yarn build
3232
yarn storybook:build

.storybook/rollup.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ const es6Bundle = {
2727
output: {
2828
dir: 'assets',
2929
entryFileNames: 'mgt.storybook.js',
30-
format: 'esm',
30+
format: 'esm'
3131
},
3232
plugins: [
3333
babel({

packages/mgt-components/src/components/mgt-people-picker/mgt-people-picker.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -937,7 +937,9 @@ export class MgtPeoplePicker extends MgtTemplatedComponent {
937937
id="suggestions-list"
938938
aria-label="${this.strings.suggestedContacts}"
939939
class="people-list"
940-
role="listbox">
940+
role="listbox"
941+
aria-live="polite"
942+
>
941943
${repeat(
942944
filteredPeople,
943945
person => person.id,

0 commit comments

Comments
 (0)