Update timeCache of cached users without photo following recheck for photo via graph (#1247)

NathZ1 · nmetulev · beth-panx · web-flow · commit 5e1e8e226463 · 2021-07-19T14:34:51.000-07:00
* Update timeCache of cached users without photo following recheck for photo via graph

* Update packages/mgt-components/src/graph/graph.userWithPhoto.ts

Co-authored-by: Nikola Metulev &lt;nmetulev@users.noreply.github.com&gt;
Co-authored-by: Beth Pan &lt;beth_panx@hotmail.com&gt;
diff --git a/packages/mgt-components/src/graph/graph.userWithPhoto.ts b/packages/mgt-components/src/graph/graph.userWithPhoto.ts
@@ -73,7 +73,12 @@ export async function getUserWithPhoto(
         } else {
           cachedPhoto = null;
         }
-      } catch (e) {}
+      } catch (e) {
+        //if 404 received (photo not found) but user already in cache, update timeCache value to prevent repeated 404 error / graph calls on each page refresh
+        if (e.code === 'ErrorItemNotFound') {
+          storePhotoInCache(userId || 'me', schemas.photos.stores.users, { eTag: null, photo: null });
+        }
+      }
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,12 @@ export async function getUserWithPhoto(`
`73`	`73`	`} else {`
`74`	`74`	`cachedPhoto = null;`
`75`	`75`	`}`
`76`		`- } catch (e) {}`
	`76`	`+ } catch (e) {`
	`77`	`+ //if 404 received (photo not found) but user already in cache, update timeCache value to prevent repeated 404 error / graph calls on each page refresh`
	`78`	`+ if (e.code === 'ErrorItemNotFound') {`
	`79`	`+ storePhotoInCache(userId \|\| 'me', schemas.photos.stores.users, { eTag: null, photo: null });`
	`80`	`+ }`
	`81`	`+ }`
`77`	`82`	`}`
`78`	`83`	`}`
`79`	`84`