Skip to content

Commit 998ac32

Browse files
committed
adding nohoist rules to ensure that spfx projects build without errors
1 parent bfd19e8 commit 998ac32

File tree

2 files changed

+29
-22
lines changed

2 files changed

+29
-22
lines changed

package.json

Lines changed: 20 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,26 +2,33 @@
22
"name": "root",
33
"private": true,
44
"version": "3.0.0",
5-
"workspaces": [
6-
"packages/*",
7-
"packages/providers/*",
8-
"samples/react-app",
9-
"samples/angular-app",
10-
"samples/vue-app",
11-
"samples/electron-app",
12-
"samples/sp-webpart",
13-
"samples/sp-mgt",
14-
"samples/teamsfx-app/tabs"
15-
],
5+
"workspaces": {
6+
"packages": [
7+
"packages/*",
8+
"packages/providers/*",
9+
"samples/react-app",
10+
"samples/angular-app",
11+
"samples/vue-app",
12+
"samples/electron-app",
13+
"samples/sp-webpart",
14+
"samples/sp-mgt",
15+
"samples/teamsfx-app/tabs"
16+
],
17+
"nohoist": [
18+
"**/@microsoft/sp*",
19+
"**/@microsoft/eslint*",
20+
"**/@rushstack/*"
21+
]
22+
},
1623
"scripts": {
1724
"build": "npm run prettier:check && npm run clean && lerna run build --scope @microsoft/*",
1825
"build:compile": "npm run prettier:check && npm run clean && lerna run build:compile --scope @microsoft/*",
1926
"build:mgt": "cd ./packages/mgt && npm run build",
2027
"build:mgt-element": "cd ./packages/mgt-element && npm run build",
2128
"build:mgt-components": "cd ./packages/mgt-components && npm run build",
2229
"build:mgt-react": "lerna run build --scope @microsoft/mgt-react",
23-
"build:sp-webpart": "lerna run package --scope mgt-demo",
24-
"build:sp-mgt": "lerna run package --scope sp-mgt-no-framework",
30+
"build:sp-webpart": "lerna run build --scope mgt-demo",
31+
"build:sp-mgt": "lerna run build --scope sp-mgt-no-framework",
2532
"package:sp-webpart": "lerna run package --scope mgt-demo",
2633
"package:sp-mgt": "lerna run package --scope sp-mgt-no-framework",
2734
"bundle": "cd ./packages/mgt && npm run bundle",

samples/sp-webpart/package.json

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@
1313
"dependencies": {
1414
"@microsoft/mgt-react": "*",
1515
"@microsoft/mgt-spfx": "*",
16-
"@microsoft/sp-core-library": "1.15.0",
17-
"@microsoft/sp-lodash-subset": "1.15.0",
18-
"@microsoft/sp-office-ui-fabric-core": "1.15.0",
19-
"@microsoft/sp-property-pane": "1.15.0",
20-
"@microsoft/sp-webpart-base": "1.15.0",
16+
"@microsoft/sp-core-library": "1.15.2",
17+
"@microsoft/sp-lodash-subset": "1.15.2",
18+
"@microsoft/sp-office-ui-fabric-core": "1.15.2",
19+
"@microsoft/sp-property-pane": "1.15.2",
20+
"@microsoft/sp-webpart-base": "1.15.2",
2121
"office-ui-fabric-react": "7.185.7",
2222
"react": "16.9.0",
2323
"react-dom": "16.9.0"
@@ -26,11 +26,11 @@
2626
"@types/react": "16.9.36"
2727
},
2828
"devDependencies": {
29-
"@microsoft/eslint-config-spfx": "1.15.0",
30-
"@microsoft/eslint-plugin-spfx": "1.15.0",
29+
"@microsoft/eslint-config-spfx": "1.15.2",
30+
"@microsoft/eslint-plugin-spfx": "1.15.2",
3131
"@microsoft/rush-stack-compiler-4.5": "0.2.2",
32-
"@microsoft/sp-build-web": "1.15.0",
33-
"@microsoft/sp-module-interfaces": "1.15.0",
32+
"@microsoft/sp-build-web": "1.15.2",
33+
"@microsoft/sp-module-interfaces": "1.15.2",
3434
"@types/react": "16.9.36",
3535
"@types/react-dom": "16.9.8",
3636
"@types/webpack-env": "1.13.1",

0 commit comments

Comments
 (0)