fix: include ImageNotFound error code to avoid unnecessary refetching (#1854)

ortegarenzy · Renzy Ortega · web-flow · commit b8d6891e7a02 · 2022-09-14T14:53:57.000+03:00
Co-authored-by: Renzy Ortega &lt;renzy.ortega@jobandesther.com&gt;
diff --git a/packages/mgt-components/src/graph/graph.userWithPhoto.ts b/packages/mgt-components/src/graph/graph.userWithPhoto.ts
@@ -75,7 +75,7 @@ export async function getUserWithPhoto(
         }
       } catch (e) {
         //if 404 received (photo not found) but user already in cache, update timeCache value to prevent repeated 404 error / graph calls on each page refresh
-        if (e.code === 'ErrorItemNotFound') {
+        if (e.code === 'ErrorItemNotFound' || e.code === 'ImageNotFound') {
           storePhotoInCache(userId || 'me', schemas.photos.stores.users, { eTag: null, photo: null });
         }
       }

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ export async function getUserWithPhoto(`
`75`	`75`	`}`
`76`	`76`	`} catch (e) {`
`77`	`77`	`//if 404 received (photo not found) but user already in cache, update timeCache value to prevent repeated 404 error / graph calls on each page refresh`
`78`		`- if (e.code === 'ErrorItemNotFound') {`
	`78`	`+ if (e.code === 'ErrorItemNotFound' \|\| e.code === 'ImageNotFound') {`
`79`	`79`	`storePhotoInCache(userId \|\| 'me', schemas.photos.stores.users, { eTag: null, photo: null });`
`80`	`80`	`}`
`81`	`81`	`}`