Skip to content

Commit e672eb3

Browse files
authored
people-picker default-selected-user-ids removal fix (#552)
* prettier, types * adding story
1 parent 6269001 commit e672eb3

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

packages/mgt/src/components/mgt-people-picker/mgt-people-picker.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -269,6 +269,8 @@ export class MgtPeoplePicker extends MgtTemplatedComponent {
269269
private _groupPeople: IDynamicPerson[];
270270
private _debouncedSearch: { (): void; (): void };
271271

272+
private defaultSelectedUsers: IDynamicPerson[];
273+
272274
@internalProperty() private _isFocused = false;
273275

274276
@internalProperty() private _foundPeople: IDynamicPerson[];
@@ -658,10 +660,10 @@ export class MgtPeoplePicker extends MgtTemplatedComponent {
658660
}
659661
this._showLoading = false;
660662

661-
if (this.defaultSelectedUserIds && !this.selectedPeople.length) {
662-
const defaultSelectedUsers = await getUsersForUserIds(graph, this.defaultSelectedUserIds);
663+
if (this.defaultSelectedUserIds && !this.selectedPeople.length && !this.defaultSelectedUsers) {
664+
this.defaultSelectedUsers = await getUsersForUserIds(graph, this.defaultSelectedUserIds);
663665

664-
this.selectedPeople = [...defaultSelectedUsers];
666+
this.selectedPeople = [...this.defaultSelectedUsers];
665667
this.requestUpdate();
666668
this.fireCustomEvent('selectionChanged', this.selectedPeople);
667669
}

stories/components/peoplePicker.stories.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,3 +75,9 @@ export const pickerOverflowGradient = () => html`
7575
}
7676
</style>
7777
`;
78+
79+
export const pickerDefaultSelectedUserIds = () => html`
80+
<mgt-people-picker
81+
default-selected-user-ids="e3d0513b-449e-4198-ba6f-bd97ae7cae85, 40079818-3808-4585-903b-02605f061225"
82+
></mgt-people-picker>
83+
`;

0 commit comments

Comments
 (0)