Skip to content

Commit fb465fe

Browse files
authored
Merge branch 'master' into nivogt/people-picker-group
2 parents 5a24d14 + 48c6f4c commit fb465fe

File tree

5 files changed

+33
-20
lines changed

5 files changed

+33
-20
lines changed

samples/react-app/package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
{
22
"name": "react-app",
3-
"version": "0.1.0",
3+
"version": "1.3.0",
44
"private": true,
55
"dependencies": {
6-
"@microsoft/mgt": "0.1.0-preview.8",
6+
"@microsoft/mgt": "^1.3.0-preview.3",
7+
"@microsoft/mgt-react": "^1.3.0-preview.3",
78
"@webcomponents/webcomponentsjs": "2.2.10",
89
"react": "^16.8.5",
910
"react-app-polyfill": "1.0.1",

samples/react-app/src/App.js

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,24 @@
11
import React, { Component } from 'react';
2-
import "@microsoft/mgt";
2+
import { Login, Agenda, Person} from '@microsoft/mgt-react';
3+
import { PersonViewType } from '@microsoft/mgt';
34

45
class App extends Component {
56
render() {
7+
8+
const personDetails = {
9+
displayName: 'Nikola Metulev'
10+
};
11+
612
return (
713
<div className="App">
8-
<mgt-login ref="loginComponent"></mgt-login>
9-
<mgt-agenda group-by-day></mgt-agenda>
14+
<Login loginCompleted={()=> console.log('login completed')}/>
15+
<Agenda groupByDay="true"/>
1016

1117

12-
<mgt-person show-name ref={el => el.personDetails = {displayName: 'Nikola Metulev'}}></mgt-person>
18+
<Person personDetails={personDetails} view={PersonViewType.oneline}/>
1319
</div>
1420
);
1521
}
16-
17-
componentDidMount() {
18-
this.refs.loginComponent.addEventListener('loginCompleted', e => {
19-
console.log('logincompleted');
20-
});
21-
}
2222
}
2323

2424
export default App;

src/components/mgt-people-picker/mgt-people-picker.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ mgt-people-picker .root {
4545
:host .people-picker,
4646
mgt-people-picker .people-picker {
4747
position: relative;
48-
margin: 7px 0 0 0;
4948
background-color: $input-background-color;
5049
padding-bottom: 6px;
5150
border: $input-border;

src/components/mgt-teams-channel-picker/mgt-teams-channel-picker.scss

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ $dropdown-item-selected-background: var(--dropdown-item-selected-background, #de
6767
.channel-chosen-list {
6868
min-height: 29px;
6969
display: flex;
70-
flex-wrap: wrap;
70+
flex-wrap: nowrap;
7171
vertical-align: middle;
7272
margin: 0 0 0 0;
7373
list-style-type: none;
@@ -106,7 +106,7 @@ $dropdown-item-selected-background: var(--dropdown-item-selected-background, #de
106106
font-weight: normal;
107107
font-size: 14px;
108108
line-height: 19px;
109-
background-color: $input-background-color;
109+
background-color: transparent;
110110
color: $font-color;
111111
padding-left: 5px;
112112
&::placeholder {
@@ -120,7 +120,8 @@ $dropdown-item-selected-background: var(--dropdown-item-selected-background, #de
120120
.close-icon {
121121
display: inline-block;
122122
position: absolute;
123-
right: 10px;
123+
right: 0;
124+
padding: 10px;
124125
line-height: normal;
125126
font-family: 'FabricMDL2Icons';
126127
margin-bottom: 1px;

src/components/mgt-teams-channel-picker/mgt-teams-channel-picker.ts

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ export class MgtTeamsChannelPicker extends MgtTemplatedComponent {
287287
${!this._selectedItemState ? getSvg(SvgIcon.Search, '#252424') : ''}
288288
</div>
289289
<div class="channel-chosen-list">
290-
${this.renderSelected()} ${this.renderInput()}
290+
${this.renderSelected()} ${this.renderInput()} ${this.renderCloseButton()}
291291
</div>
292292
</div>
293293
<div class=${classMap(dropdownClasses)}>${this.renderDropdown()}</div>
@@ -313,9 +313,6 @@ export class MgtTeamsChannelPicker extends MgtTemplatedComponent {
313313
<div class="selected-team-name">${this._selectedItemState.parent.item.displayName}</div>
314314
<div class="arrow">${getSvg(SvgIcon.TeamSeparator, '#B3B0AD')}</div>
315315
${this._selectedItemState.item.displayName}
316-
<div class="close-icon" @click="${() => this.selectChannel(null)}">
317-
318-
</div>
319316
</li>
320317
<div class="search-icon">
321318
${this._isFocused ? getSvg(SvgIcon.Search, '#252424') : ''}
@@ -352,6 +349,21 @@ export class MgtTeamsChannelPicker extends MgtTemplatedComponent {
352349
`;
353350
}
354351

352+
/**
353+
* Renders close button
354+
*
355+
* @protected
356+
* @returns
357+
* @memberof MgtTeamsChannelPicker
358+
*/
359+
protected renderCloseButton() {
360+
return html`
361+
<div class="close-icon" @click="${() => this.selectChannel(null)}">
362+
363+
</div>
364+
`;
365+
}
366+
355367
/**
356368
* Renders dropdown content
357369
*

0 commit comments

Comments
 (0)