Skip to content

Commit fd9f08e

Browse files
vogtnnmetulev
authored andcommitted
People Picker known issue fixes (#136)
* [people-picker] Adding documentation and basic custom css variables * [people-picker] removing console.log * [people-picker-documentation] fixing typo in documentation * [people-picker] updating arrow selection status * [people-picker] updating first selection is highlighted * [people-picker] updating docs to utilize real image * [people-picker] adding new file * [people-picker] changing text overflow property on selected people * [people-picker] changing text overflow property on selected people * [people-picker] updating selected people long string with css ellipses * [people-picker]updating centering of close icon * [people-picker] adding repeat instead of map, also caching images * [people-picker] adding timeout to boolean for no users found * [people-picker] updating image storing in case local storage doesn't exist * [people-picker] removing docs and adding pr fixes
1 parent 64d193b commit fd9f08e

File tree

3 files changed

+114
-92
lines changed

3 files changed

+114
-92
lines changed

samples/examples/people-picker.html

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,14 @@
1414
</head>
1515

1616
<body>
17-
<mgt-msal-provider client-id="a974dfa0-9f57-49b9-95db-90f04ce2111a"></mgt-msal-provider>
17+
<!-- <mgt-msal-provider client-id="a974dfa0-9f57-49b9-95db-90f04ce2111a"></mgt-msal-provider> -->
1818

19-
<!-- <mgt-mock-provider></mgt-mock-provider> -->
19+
<mgt-mock-provider></mgt-mock-provider>
2020

2121
<mgt-login></mgt-login>
2222

23-
<mgt-people-picker id="picker1"></mgt-people-picker>
23+
<div style="max-width: 200px"><mgt-people-picker id="picker1"></mgt-people-picker></div>
24+
<!-- <mgt-tasks></mgt-tasks> -->
2425
<h2>hello</h2>
2526

2627
<div style="position: fixed; bottom: 0;">

src/components/mgt-people-picker/mgt-people-picker.scss

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ $initials-color: var(--initials-color, white);
1616
$initials-background-color: var(--initials-background-color, #{$ms-color-magenta});
1717
$accent-color: var(--accent-color, #0078d4);
1818

19+
$people-list-background-color: var(--people-list-background-color, white);
20+
1921
:host {
2022
border-radius: 2px;
2123
}
@@ -39,7 +41,7 @@ mgt-people-picker .people-list {
3941
padding: 0;
4042
box-shadow: 0px 1.3289px 2.65781px rgba(180, 180, 180, 0.182), 0px 1.3289px 2.65781px rgba(68, 68, 68, 0.3);
4143
border-radius: 2px;
42-
background-color: white;
44+
background-color: $people-list-background-color;
4345
z-index: 1; /* Sit on top */
4446
width: 100%;
4547
text-align: left;
@@ -87,7 +89,7 @@ mgt-people-picker .CloseIcon {
8789
font-family: 'FabricMDL2Icons';
8890
padding-right: 8px;
8991
padding-left: 4px;
90-
margin-top: 3px;
92+
margin-top: 0px;
9193
}
9294
:host .SearchIcon,
9395
mgt-people-picker .SearchIcon {
@@ -102,7 +104,10 @@ mgt-people-picker .people-person {
102104
align-items: center;
103105
background-color: rgba(196, 196, 196, 0.24);
104106
border-radius: 15px;
105-
max-height: 24px;
107+
height: 24px;
108+
white-space: nowrap;
109+
overflow: hidden;
110+
text-overflow: ellipsis;
106111
}
107112

108113
:host .people-person-list,
@@ -180,6 +185,10 @@ mgt-people-picker .remove-person-button-secondary {
180185

181186
:host .person-display-name,
182187
mgt-people-picker .person-display-name {
188+
max-width: 100px;
189+
white-space: nowrap;
190+
overflow: hidden;
191+
text-overflow: ellipsis;
183192
margin-left: 8px;
184193
font-family: Segoe UI;
185194
font-style: normal;

0 commit comments

Comments
 (0)