Merge pull request #376 from hubipe/main

baywet · web-flow · commit c7c47d06e4a2 · 2025-03-28T08:37:26.000-04:00
feat: adds PHP 8.4 compatibility
diff --git a/.github/workflows/pr-validation.yml b/.github/workflows/pr-validation.yml
@@ -19,7 +19,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        php-versions: ['7.4', '8.0', '8.1', '8.2']
+        php-versions: ['7.4', '8.0', '8.1', '8.2', '8.3', '8.4']
     steps:
     - name: Setup PHP
       uses: shivammathur/setup-php@v2
diff --git a/src/GraphRequestAdapter.php b/src/GraphRequestAdapter.php
@@ -22,7 +22,7 @@ class GraphRequestAdapter extends BaseGraphRequestAdapter
      * @param AuthenticationProvider $authenticationProvider
      * @param Client|null $httpClient
      */
-    public function __construct(AuthenticationProvider $authenticationProvider, Client $httpClient = null)
+    public function __construct(AuthenticationProvider $authenticationProvider, ?Client $httpClient = null)
     {
         parent::__construct($this->getTelemetryConfig(), $authenticationProvider, null, null, $httpClient);
     }

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ class GraphRequestAdapter extends BaseGraphRequestAdapter`
`22`	`22`	`* @param AuthenticationProvider $authenticationProvider`
`23`	`23`	`* @param Client\|null $httpClient`
`24`	`24`	`*/`
`25`		`- public function __construct(AuthenticationProvider $authenticationProvider, Client $httpClient = null)`
	`25`	`+ public function __construct(AuthenticationProvider $authenticationProvider, ?Client $httpClient = null)`
`26`	`26`	`{`
`27`	`27`	`parent::__construct($this->getTelemetryConfig(), $authenticationProvider, null, null, $httpClient);`
`28`	`28`	`}`