fix: fix bug with authentication failure when environment is changed (#347)

calebkiage · web-flow · commit eba1c70f49ad · 2024-02-13T15:51:12.000Z
closes #346
diff --git a/src/Microsoft.Graph.Cli.Core/IO/AuthenticationCacheManager.cs b/src/Microsoft.Graph.Cli.Core/IO/AuthenticationCacheManager.cs
@@ -68,7 +68,7 @@ public async Task SaveAuthenticationIdentifiersAsync(string? clientId, string? t
         if (
                 clientId != authOptions.ClientId || tenantId != authOptions.TenantId || certificateName != authOptions.ClientCertificateName ||
                 certificateThumbPrint != authOptions.ClientCertificateThumbPrint || strategy != authOptions.Strategy ||
-                (authOptions.Authority is not null && adAuthority != new Uri(authOptions.Authority))
+                (authOptions.Authority is not null && adAuthority != new Uri(authOptions.Authority)) || environment != authOptions.Environment
         )
         {
             configuration.AuthenticationOptions = new AuthenticationOptions

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ public async Task SaveAuthenticationIdentifiersAsync(string? clientId, string? t`
`68`	`68`	`if (`
`69`	`69`	`clientId != authOptions.ClientId \|\| tenantId != authOptions.TenantId \|\| certificateName != authOptions.ClientCertificateName \|\|`
`70`	`70`	`certificateThumbPrint != authOptions.ClientCertificateThumbPrint \|\| strategy != authOptions.Strategy \|\|`
`71`		`- (authOptions.Authority is not null && adAuthority != new Uri(authOptions.Authority))`
	`71`	`+ (authOptions.Authority is not null && adAuthority != new Uri(authOptions.Authority)) \|\| environment != authOptions.Environment`
`72`	`72`	`)`
`73`	`73`	`{`
`74`	`74`	`configuration.AuthenticationOptions = new AuthenticationOptions`