Update graph cli core version (#250)

* Update graph cli core version

* Add git attributes

* Update generated code. (#251)

Schema version: microsoftgraph/msgraph-metadata@f9043275
Generator version: microsoft/kiota@dde63cef

* Enable git long paths support for windows hosts

* Add format checking stage (disabled)

* Try to get an error message from an ODataError

Author: calebkiage

.azure-pipelines/release-cli.yaml

@@ -37,10 +37,11 @@ variables:
       value: '$(Build.SourceBranchName)'
   - group: ESRP
 
-#                   
-# test -> build -> | sign |
-#                  |------| -> upload
-# srcScan -------> | scan |
+# test ----------> | build ->   |            |
+#                  |            | sign       |
+# checkFormat ----------------> |------------| -> upload
+#                               | binaryScan |
+# srcScan --------------------> |            |
 stages:
   - stage: test
     displayName: Run tests
@@ -113,6 +114,29 @@ stages:
               artifact: build-output-$(rid)
               path: $(outputDir)-$(rid)
 
+    # Format takes a long time. keep it in its own stage
+  - stage: checkFormat
+    displayName: Check formatting
+    condition: false
+    dependsOn: []
+    jobs:
+      - job: checkFormat
+        displayName: Check formatting
+        steps:
+        - task: UseDotNet@2
+          displayName: 'Use .NET 7'
+          inputs:
+            version: 7.x
+
+        # Restore NuGet packages (enables cache by default)
+        - template: templates/nuget-packages.yaml
+          parameters:
+            vstsFeedName: ${{variables.internalFeed}}
+
+        - pwsh: dotnet format --no-restore --include ./src/ --exclude ./src/generated/ --verify-no-changes
+          displayName: Validate formatting
+          enabled: true
+
   - stage: srcScan
     displayName: Scan source code
     pool:
@@ -226,12 +250,17 @@ stages:
               Write-Host "##vso[task.setvariable variable=WORKING_DIR]$(artifactsDownloadLocation)/$(rid)"
             displayName: Setup variables
 
+          - pwsh: git config --global core.longpaths true
+            displayName: Enable git's long file paths on Windows
+
+          - checkout: self
+
           - task: DownloadPipelineArtifact@2
             inputs:
               patterns: build-output-$(rid)/**/*
               path: $(WORKING_DIR)
             condition: and(succeeded(), eq(variables['SHOULD_SIGN'], 'True'))
-          
+
           - pwsh: |
               Import-Module $(powershellScriptsDir)/BuildTools.psm1
               $zipName = Get-ZipName -FileNameTemplate '$(zipTemplate)' -BranchOrTagName '$(branchOrTagName)' -RuntimeIdentifier '$(rid)'
@@ -316,7 +345,7 @@ stages:
 
   - stage: binaryScan
     displayName: Scan binaries (Anti malware, BinSkim)
-    dependsOn: [build, srcScan]
+    dependsOn: [build, checkFormat, srcScan]
     pool:
       vmImage: windows-latest
     # Only scan binaries if we're building a tag, building main, or building a PR targeting main
@@ -359,4 +388,3 @@ stages:
                 $(artifactsDownloadLocation)/build-output-linux-*/*.zip
                 $(artifactsDownloadLocation)/sign-output-*/*.zip
               isPreRelease: $(isPreRelease)
-    

.azure-pipelines/templates/compliance-checks.yaml

@@ -16,6 +16,11 @@ steps:
 
   - ${{ if ne(parameters.scanSource, true) }}:
     - checkout: none
+  - ${{ else }}:
+    - pwsh: git config --global core.longpaths true
+      displayName: Enable git's long file paths on Windows
+
+    - checkout: self
 
   - ${{ if eq(parameters.scanSource, true) }}:
     - task: PoliCheck@2

.editorconfig

@@ -0,0 +1,129 @@
+# EditorConfig is awesome: https://EditorConfig.org
+
+# top-most EditorConfig file
+root = true
+
+[*]
+indent_style = space
+indent_size = 4
+end_of_line = crlf
+charset = utf-8
+trim_trailing_whitespace = true
+insert_final_newline = true
+
+[*.{y[a]ml,json}]
+indent_size = 2
+
+# VSCode generates files with 4 spaces
+[.vscode/*.json]
+indent_size = 4
+
+# Code files
+[*.{cs,csx,vb,vbx}]
+indent_size = 4
+charset = utf-8-bom
+###############################
+# .NET Coding Conventions     #
+###############################
+[*.{cs,vb}]
+# Organize usings
+dotnet_sort_system_directives_first = true
+# this. preferences
+dotnet_style_qualification_for_field = false:silent
+dotnet_style_qualification_for_property = false:silent
+dotnet_style_qualification_for_method = false:silent
+dotnet_style_qualification_for_event = false:silent
+# Language keywords vs BCL types preferences
+dotnet_style_predefined_type_for_locals_parameters_members = true:silent
+dotnet_style_predefined_type_for_member_access = true:silent
+# Parentheses preferences
+dotnet_style_parentheses_in_arithmetic_binary_operators = always_for_clarity:silent
+dotnet_style_parentheses_in_relational_binary_operators = always_for_clarity:silent
+dotnet_style_parentheses_in_other_binary_operators = always_for_clarity:silent
+dotnet_style_parentheses_in_other_operators = never_if_unnecessary:silent
+# Modifier preferences
+dotnet_style_require_accessibility_modifiers = for_non_interface_members:silent
+dotnet_style_readonly_field = true:suggestion
+# Expression-level preferences
+dotnet_style_object_initializer = true:suggestion
+dotnet_style_collection_initializer = true:suggestion
+dotnet_style_explicit_tuple_names = true:suggestion
+dotnet_style_null_propagation = true:suggestion
+dotnet_style_coalesce_expression = true:suggestion
+dotnet_style_prefer_is_null_check_over_reference_equality_method = true:silent
+dotnet_style_prefer_inferred_tuple_names = true:suggestion
+dotnet_style_prefer_inferred_anonymous_type_member_names = true:suggestion
+dotnet_style_prefer_auto_properties = true:silent
+dotnet_style_prefer_conditional_expression_over_assignment = true:silent
+dotnet_style_prefer_conditional_expression_over_return = true:silent
+###############################
+# Naming Conventions          #
+###############################
+# Style Definitions
+dotnet_naming_style.pascal_case_style.capitalization             = pascal_case
+# Use PascalCase for constant fields
+dotnet_naming_rule.constant_fields_should_be_pascal_case.severity = suggestion
+dotnet_naming_rule.constant_fields_should_be_pascal_case.symbols  = constant_fields
+dotnet_naming_rule.constant_fields_should_be_pascal_case.style    = pascal_case_style
+dotnet_naming_symbols.constant_fields.applicable_kinds            = field
+dotnet_naming_symbols.constant_fields.applicable_accessibilities  = *
+dotnet_naming_symbols.constant_fields.required_modifiers          = const
+###############################
+# C# Coding Conventions       #
+###############################
+[*.cs]
+# var preferences
+csharp_style_var_for_built_in_types = true:silent
+csharp_style_var_when_type_is_apparent = true:silent
+csharp_style_var_elsewhere = true:silent
+# Expression-bodied members
+csharp_style_expression_bodied_methods = false:silent
+csharp_style_expression_bodied_constructors = false:silent
+csharp_style_expression_bodied_operators = false:silent
+csharp_style_expression_bodied_properties = true:silent
+csharp_style_expression_bodied_indexers = true:silent
+csharp_style_expression_bodied_accessors = true:silent
+# Pattern matching preferences
+csharp_style_pattern_matching_over_is_with_cast_check = true:suggestion
+csharp_style_pattern_matching_over_as_with_null_check = true:suggestion
+# Null-checking preferences
+csharp_style_throw_expression = true:suggestion
+csharp_style_conditional_delegate_call = true:suggestion
+# Modifier preferences
+csharp_preferred_modifier_order = public,private,protected,internal,static,extern,new,virtual,abstract,sealed,override,readonly,unsafe,volatile,async:suggestion
+# Expression-level preferences
+csharp_prefer_braces = true:silent
+csharp_style_deconstructed_variable_declaration = true:suggestion
+csharp_prefer_simple_default_expression = true:suggestion
+csharp_style_pattern_local_over_anonymous_function = true:suggestion
+csharp_style_inlined_variable_declaration = true:suggestion
+###############################
+# C# Formatting Rules         #
+###############################
+# New line preferences
+csharp_new_line_before_open_brace = all
+csharp_new_line_before_else = true
+csharp_new_line_before_catch = true
+csharp_new_line_before_finally = true
+csharp_new_line_before_members_in_object_initializers = true
+csharp_new_line_before_members_in_anonymous_types = true
+csharp_new_line_between_query_expression_clauses = true
+# Indentation preferences
+csharp_indent_case_contents = true
+csharp_indent_switch_labels = true
+csharp_indent_labels = flush_left
+# Space preferences
+csharp_space_after_cast = false
+csharp_space_after_keywords_in_control_flow_statements = true
+csharp_space_between_method_call_parameter_list_parentheses = false
+csharp_space_between_method_declaration_parameter_list_parentheses = false
+csharp_space_between_parentheses = false
+csharp_space_before_colon_in_inheritance_clause = true
+csharp_space_after_colon_in_inheritance_clause = true
+csharp_space_around_binary_operators = before_and_after
+csharp_space_between_method_declaration_empty_parameter_list_parentheses = false
+csharp_space_between_method_call_name_and_opening_parenthesis = false
+csharp_space_between_method_call_empty_parameter_list_parentheses = false
+# Wrapping preferences
+csharp_preserve_single_line_statements = true
+csharp_preserve_single_line_blocks = false

.gitattributes

@@ -0,0 +1,20 @@
+# Set the default behavior, in case people don't have core.autocrlf set.
+* text=auto
+
+# Explicitly declare text files you want to always be normalized and converted
+# to native line endings on checkout.
+*.json text
+*.ps[m]1 text
+
+# Declare files that will always have CRLF line endings on checkout.
+*.sh text eol=lf
+*.plist text eol=lf
+
+# Declare files that will always have CRLF line endings on checkout.
+*.sln text eol=crlf
+*.cs text eol=crlf
+*.csproj text eol=crlf
+
+# Denote all files that are truly binary and should not be modified.
+*.png binary
+*.jpg binary

.vscode/settings.json

@@ -0,0 +1,3 @@
+{
+    "omnisharp.organizeImportsOnFormat": true
+}

omnisharp.json

@@ -0,0 +1,5 @@
+{
+  "FormattingOptions": {
+    "EnableEditorConfigSupport": true
+  }
+}