Skip to content

Commit 163df93

Browse files
authored
Merge pull request #683 from microsoftgraph/andrueastman/Bumpcore
Bumps http library version for base url fix.
2 parents dcecf6b + d412a50 commit 163df93

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed

src/Microsoft.Graph.Core/Microsoft.Graph.Core.csproj

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,10 @@
2121
<DelaySign>false</DelaySign>
2222
<AssemblyOriginatorKeyFile>35MSSharedLib1024.snk</AssemblyOriginatorKeyFile>
2323
<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
24-
<VersionPrefix>3.0.8</VersionPrefix>
24+
<VersionPrefix>3.0.9</VersionPrefix>
2525
<VersionSuffix></VersionSuffix>
2626
<PackageReleaseNotes>
27-
- Fixes nextLink loop exception when making delta requests with the page iterator(https://github.com/microsoftgraph/msgraph-sdk-dotnet/issues/1948)
28-
- Bumps kiota abstraction packages to fix bugs in Backing store and allow large stream downloads.
27+
- Fixes regression in url building when the httpClient base addresss is used.
2928
</PackageReleaseNotes>
3029
<PublishRepositoryUrl>true</PublishRepositoryUrl>
3130
<EmbedUntrackedSources>true</EmbedUntrackedSources>
@@ -64,7 +63,7 @@
6463
<PackageReference Include="Microsoft.Kiota.Serialization.Json" Version="1.0.6" />
6564
<PackageReference Include="Microsoft.Kiota.Serialization.Text" Version="1.0.1" />
6665
<PackageReference Include="Microsoft.Kiota.Serialization.Form" Version="1.0.1" />
67-
<PackageReference Include="Microsoft.Kiota.Http.HttpClientLibrary" Version="1.0.4" />
66+
<PackageReference Include="Microsoft.Kiota.Http.HttpClientLibrary" Version="1.0.5" />
6867
</ItemGroup>
6968
<ItemGroup Condition=" '$(TargetFramework)' != 'netstandard2.0' ">
7069
<PackageReference Include="NETStandard.Library" Version="2.0.3" />

tests/Microsoft.Graph.DotnetCore.Core.Test/Requests/BaseClientTests.cs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,15 @@ public void BaseClient_InitializeBaseUrlWithoutTrailingSlash()
2626

2727
Assert.Equal(expectedBaseUrl, baseClient.RequestAdapter.BaseUrl);
2828
}
29+
30+
[Fact]
31+
public void BaseClient_InitializeBaseUrlTrailingSlash()
32+
{
33+
var expectedBaseUrl = "https://localhost";
34+
35+
var baseClient = new BaseClient("https://localhost/", this.authenticationProvider.Object);
36+
37+
Assert.Equal(expectedBaseUrl, baseClient.RequestAdapter.BaseUrl);
38+
}
2939
}
3040
}

0 commit comments

Comments
 (0)