Merge pull request #97 from microsoftgraph/revert-80-exposeResponseHeadersInException

Revert "Provided pass through of response headers and status code for excepti…"

Author: MIchaelMainer

src/Microsoft.Graph.Core/Exceptions/ServiceException.cs

@@ -5,7 +5,6 @@
 namespace Microsoft.Graph
 {
     using System;
-    using System.Collections.Generic;
 
     public class ServiceException : Exception
     {
@@ -17,11 +16,6 @@ public ServiceException(Error error, Exception innerException = null)
 
         public Error Error { get; private set; }
 
-        // ResponseHeaders and StatusCode exposed as pass-through.
-        public System.Net.Http.Headers.HttpResponseHeaders ResponseHeaders { get; internal set; }
-
-        public System.Net.HttpStatusCode StatusCode { get; internal set; } 
-
         public bool IsMatch(string errorCode)
         {
             if (string.IsNullOrEmpty(errorCode))

src/Microsoft.Graph.Core/Requests/HttpProvider.cs

@@ -203,15 +203,8 @@ public async Task<HttpResponseMessage> SendAsync(
                             error.ThrowSite = throwsiteValues.FirstOrDefault();
                         }
                     }
-                    
-                    throw new ServiceException(error)
-                    {
-                        // Pass through the response headers to the ServiceException.
-                        ResponseHeaders = response.Headers,
 
-                        // Pass through the HTTP status code.
-                        StatusCode = response.StatusCode
-                    };
+                    throw new ServiceException(error);
                 }
             }
 

tests/Microsoft.Graph.Test/Requests/Functional/MailTests.cs

@@ -10,42 +10,7 @@ namespace Microsoft.Graph.Test.Requests.Functional
     [TestClass]
     public class MailTests : GraphTestBase
     {
-        [Ignore] // Setup Fiddler autoresponder 
-        [TestMethod]
-        public async Task MailGetGroupWithThrottlingError()
-        {
-            try
-            {
-                // All requests should have a client-request-id set so that the client can correlate a 
-                // request with a response. 
-                var headerOptions = new List<HeaderOption>()
-                {
-                    new HeaderOption("client-request-id", new Guid("dddddddd-dddd-dddd-dddd-dddddddddddd").ToString())
-                };
-
-                // To get a throttling error, I mocked up a 429 response in a text file and turned on the Fiddler
-                // autoresponder to return the text file as the response envelope. The autoresponder for this 
-                // scenario responds to EXACT:https://graph.microsoft.com/v1.0/groups/036bd54c-c6e5-43eb-b8b5-03e019e75bd1
-                var group = await graphClient.Groups["036bd54c-c6e5-43eb-b8b5-03e019e75bd1"].Request(headerOptions).GetAsync();
-            }
-            catch (Microsoft.Graph.ServiceException e)
-            {
-                if ((int)e.StatusCode == 429) // Too Many Requests
-                {
-                    // We have the client-request-id for correlating the response to the request that failed.
-                    IEnumerable<string> clientrequestidvalues;
-                    Assert.IsTrue(e.ResponseHeaders.TryGetValues("client-request-id", out clientrequestidvalues));
 
-                    // We have the Retry-After that the client can use to wait and resubmit the rejected request.
-                    IEnumerable<string> retryaftervalues;
-                    Assert.IsTrue(e.ResponseHeaders.TryGetValues("Retry-After", out retryaftervalues));
-                }
-                else
-                {
-                    Assert.Fail("Something happened, check out a trace. Error code: {0}", e.Error.Code);
-                }
-            }
-        }
 
         public async Task<Message> createEmail(string emailBody)
         {