ODataError vs ServiceException

[drilko]

Describe the bug

Hi,

I think there is some confusion about error handling when using MS Graph SDK.

For example, when using DeltaRequestBuilder.GetAsDeltaGetResponseAsync it throws an ODataError, but when using PageIterator<DriveItem, DeltaGetResponse>.CreatePageIterator it throws a ServiceException.

The main problem is that everything is basically null or empty on ServiceException:

• ResponseHeaders - empty
• RawResponseBody - null
• AdditionalData - empty
• ResponseHeaders - null

There is no proper way to find any relevant information to handle this exception. I've only managed to do it through a Message property like so:

catch (ServiceException ex) when (ex.InnerException?.Message.StartsWith(GraphErrorCode.ResyncRequired.ToString(), StringComparison.OrdinalIgnoreCase) == true)
{
  // Handle the exception
}

Is this a bug or is there a reason for this because the docs mention only ODataError and the upgrade-to-v5 also mentions only ODataError?

Expected behavior

Using PageIterator<DriveItem, DeltaGetResponse>.CreatePageIterator throws an ODataError or relevant properties on ServiceException have values.

How to reproduce

I don't have exact repro steps because what happens is this:

• First Graph API call is success (using DeltaRequestBuilder.GetAsDeltaGetResponseAsync)
• Second call via the iterator results in 410 resyncRequired and throws a ServiceException

SDK Version

5.51.0

Latest version known to work for scenario above?

No response

Known Workarounds

No response

Debug output

Configuration

No response

Other information

No response

[baywet]

Thank you for using the SDK and for reaching out!

This is working as designed. The ServiceException is used for manually implemented parts of the SDK (such as paging), while the ODataError is used for the generated parts of the SDK (such as listing users).

The ServiceException does provide access to the response headers. You can see the implementation here: https://github.com/microsoftgraph/msgraph-sdk-dotnet-core/blob/aee58489ff89d89ea20ed3825224a6339858d980/src/Microsoft.Graph.Core/Exceptions/ServiceException.cs#L37

As for capturing the response body, this could be implemented using a middleware handler to intercept and store the raw response as needed.

Please let us know if you have any other questions or need further assistance.

[microsoft-github-policy-service]

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.