- fixes a bug where collections of primitives would not be deserialized properly

Author: baywet

src/main/java/com/microsoft/graph/serializer/CollectionResponseSerializer.java

@@ -33,6 +33,7 @@
 import com.google.gson.JsonElement;
 import com.google.gson.JsonObject;
 import com.google.gson.JsonParseException;
+import com.google.gson.JsonPrimitive;
 import com.microsoft.graph.http.BaseCollectionResponse;
 import com.microsoft.graph.logger.ILogger;
 
@@ -96,6 +97,14 @@ public static <T1> BaseCollectionResponse<T1> deserialize(@Nonnull final JsonEle
                     final T1 targetObject = (T1)serializer.deserializeObject(sourceObject, entityClass);
                     ((IJsonBackedObject)targetObject).setRawObject(serializer, sourceObject);
                     list.add(targetObject);
+                } else if (sourceElement.isJsonPrimitive()) {
+                    final JsonPrimitive primitiveValue = sourceElement.getAsJsonPrimitive();
+                    if(primitiveValue.isString())
+                        list.add((T1)primitiveValue.getAsString());
+                    else if(primitiveValue.isBoolean())
+                        list.add((T1) Boolean.valueOf(primitiveValue.getAsBoolean()));
+                    else if(primitiveValue.isNumber())
+                        list.add((T1) Long.valueOf(primitiveValue.getAsLong()));
                 }
             }
             final BaseCollectionResponse<T1> response = (BaseCollectionResponse<T1>)responseClass.getConstructor().newInstance();

src/test/java/com/microsoft/graph/serializer/CollectionResponseOfPrimitives.java

@@ -0,0 +1,6 @@
+package com.microsoft.graph.serializer;
+
+import com.microsoft.graph.http.BaseCollectionResponse;
+
+public class CollectionResponseOfPrimitives extends BaseCollectionResponse<String> {
+}

src/test/java/com/microsoft/graph/serializer/CollectionResponseOfPrimitivesTests.java

@@ -0,0 +1,23 @@
+package com.microsoft.graph.serializer;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.mockito.Mockito.mock;
+
+import com.microsoft.graph.logger.ILogger;
+
+import org.junit.jupiter.api.Test;
+
+public class CollectionResponseOfPrimitivesTests {
+    @Test
+    void DeserializesCollectionOfStrings() {
+        final var serializer = new DefaultSerializer(mock(ILogger.class));
+        final var serializedValue = "{\"@odata.context\": \"https://graph.microsoft.com/v1.0/$metadata#Collection(Edm.String)\",\"value\": [\"b72e90c8-3d3a-457e-8ca0-0fdde204d320\"]}";
+        final var result = serializer.deserializeObject(serializedValue, CollectionResponseOfPrimitives.class);
+        assertNotNull(result);
+        assertNotNull(result.value);
+        assertNotNull(result.additionalDataManager());
+        assertEquals("https://graph.microsoft.com/v1.0/$metadata#Collection(Edm.String)", result.additionalDataManager().get("@odata.context").getAsString());
+        assertEquals(1, result.value.size());
+    }
+}