- adds unit tests for default retry and redirect options values

Author: baywet

src/test/java/com/microsoft/graph/httpcore/RedirectHandlerTest.java

@@ -1,5 +1,6 @@
 package com.microsoft.graph.httpcore;
 
+import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.junit.jupiter.api.Assertions.fail;
 
@@ -262,5 +263,20 @@ public void testGetRedirectRelativeLocationRequestURLwithSlash() throws Protocol
             String expected = "https://graph.microsoft.com/v1.0/me/testrelativeurl";
             assertTrue(request.url().toString().compareTo(expected) == 0);
     }
+    @Test
+    public void testIsRedirectedIsFalseIfExceedsMaxRedirects() throws ProtocolException, IOException {
+        RedirectOptions options = new RedirectOptions(0, null);
+        RedirectHandler redirectHandler = new RedirectHandler(options);
+        Request httppost = new Request.Builder().url(testmeurl).build();
 
+        Response response = new Response.Builder()
+                .protocol(Protocol.HTTP_1_1)
+                .code(HttpURLConnection.HTTP_SEE_OTHER)
+                .message("See Other")
+                .addHeader("location", "/testrelativeurl")
+                .request(httppost)
+                .build();
+        boolean isRedirected = redirectHandler.isRedirected(httppost, response, 1, options);
+        assertFalse(isRedirected);
+    }
 }

src/test/java/com/microsoft/graph/httpcore/middlewareoption/RedirectOptionsTest.java

@@ -0,0 +1,33 @@
+package com.microsoft.graph.httpcore.middlewareoption;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.Mockito.mock;
+
+import org.junit.jupiter.api.Test;
+
+import okhttp3.Response;
+
+public class RedirectOptionsTest {
+    @Test
+    public void constructorDefensiveProgramming() {
+        assertThrows(IllegalArgumentException.class, () -> {
+            new RedirectOptions(RedirectOptions.MAX_REDIRECTS +1, null);
+        });
+
+        assertThrows(IllegalArgumentException.class, () -> {
+            new RedirectOptions(-1, null);
+        });
+    }
+    @Test
+    public void defaultShouldRedirectValue() {
+        RedirectOptions options = new RedirectOptions();
+        assertEquals(options.shouldRedirect(), RedirectOptions.DEFAULT_SHOULD_REDIRECT);
+    }
+    @Test
+    public void defaultShouldRedirectIsTrue() {
+        Response response = mock(Response.class);
+        assertTrue(RedirectOptions.DEFAULT_SHOULD_REDIRECT.shouldRedirect(response));
+    }
+}

src/test/java/com/microsoft/graph/httpcore/middlewareoption/RetryOptionsTest.java

@@ -0,0 +1,32 @@
+package com.microsoft.graph.httpcore.middlewareoption;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+
+import org.junit.jupiter.api.Test;
+
+public class RetryOptionsTest {
+    @Test
+    public void constructorDefensiveProgramming() {
+        assertThrows(IllegalArgumentException.class, () -> {
+            new RetryOptions(null, RetryOptions.MAX_RETRIES +1, 0);
+        });
+
+        assertThrows(IllegalArgumentException.class, () -> {
+            new RetryOptions(null, RetryOptions.MAX_RETRIES, RetryOptions.MAX_DELAY +1);
+        });
+
+        assertThrows(IllegalArgumentException.class, () -> {
+            new RetryOptions(null, RetryOptions.MAX_RETRIES, -1);
+        });
+
+        assertThrows(IllegalArgumentException.class, () -> {
+            new RetryOptions(null, -1, RetryOptions.MAX_DELAY);
+        });
+    }
+    @Test
+    public void defaultShouldRetryValue() {
+        RetryOptions options = new RetryOptions();
+        assertEquals(options.shouldRetry(), RetryOptions.DEFAULT_SHOULD_RETRY);
+    }
+}