- lints serializer package

Author: baywet

src/main/java/com/microsoft/graph/serializer/DefaultSerializer.java

@@ -82,7 +82,7 @@ public <T> T deserializeObject(@Nonnull final String inputString, @Nonnull final
 	@Nullable
 	public <T> T deserializeObject(@Nonnull final InputStream inputStream, @Nonnull final Class<T> clazz, @Nonnull final Map<String, List<String>> responseHeaders) {
         T result = null;
-        try (final InputStreamReader streamReader =  new InputStreamReader(inputStream)) {
+        try (final InputStreamReader streamReader =  new InputStreamReader(inputStream, "UTF-8")) {
 			final JsonElement rawElement = gson.fromJson(streamReader, JsonElement.class);
 			result = deserializeObject(rawElement, clazz, responseHeaders);
         } catch (IOException ex) {
@@ -276,7 +276,7 @@ private void getChildAdditionalData(final IJsonBackedObject serializableObject,
 			try {
 				final Object fieldObject = field.get(serializableObject);
 				final JsonElement fieldJsonElement = outJson.get(field.getName());
-				if(fieldObject == null || field == null || fieldJsonElement == null)
+				if(fieldObject == null || fieldJsonElement == null)
 					continue;
 
 				// If the object is a HashMap, iterate through its children

src/main/java/com/microsoft/graph/serializer/GsonFactory.java

@@ -40,6 +40,7 @@
 import java.lang.reflect.Type;
 import java.text.ParseException;
 import java.time.OffsetDateTime;
+import java.util.Arrays;
 import java.util.EnumSet;
 import java.util.GregorianCalendar;
 
@@ -112,7 +113,7 @@ public JsonElement serialize(final byte[] src,
                 try {
                     return new JsonPrimitive(ByteArraySerializer.serialize(src));
                 } catch (final Exception e) {
-                    logger.logError(PARSING_MESSAGE + src, e);
+                    logger.logError(PARSING_MESSAGE + Arrays.toString(src), e);
                     return null;
                 }
             }

src/main/java/com/microsoft/graph/serializer/ISerializer.java

@@ -59,7 +59,7 @@ default <T> T deserializeObject(@Nonnull final String inputString, @Nonnull fina
      * @return                the deserialized item from the input string
      */
     @Nullable
-    <T> T deserializeObject(@Nonnull final String inputString, @Nonnull final Class<T> clazz, @Nonnull final Map<String, List<String>> responseHeaders);
+    <T> T deserializeObject(@Nonnull final String inputString, @Nonnull final Class<T> clazz, @Nullable final Map<String, List<String>> responseHeaders);
 
     /**
      * Deserialize an object from the input stream
@@ -84,7 +84,7 @@ default <T> T deserializeObject(@Nonnull final InputStream inputStream, @Nonnull
      * @return                the deserialized item from the input string
      */
     @Nullable
-    <T> T deserializeObject(@Nonnull final InputStream inputStream, @Nonnull final Class<T> clazz, @Nonnull final Map<String, List<String>> responseHeaders);
+    <T> T deserializeObject(@Nonnull final InputStream inputStream, @Nonnull final Class<T> clazz, @Nullable final Map<String, List<String>> responseHeaders);
 
     /**
      * Deserialize an object from the input JsonElement
@@ -95,7 +95,7 @@ default <T> T deserializeObject(@Nonnull final InputStream inputStream, @Nonnull
      * @return the deserialized item from the input string
      */
     @Nullable
-    default <T> T deserializeObject(@Nonnull JsonElement jsonElement, @Nonnull Class<T> clazz) {
+    default <T> T deserializeObject(@Nonnull final JsonElement jsonElement, @Nonnull final Class<T> clazz) {
         return deserializeObject(jsonElement, clazz, null);
     }
 
@@ -109,7 +109,7 @@ default <T> T deserializeObject(@Nonnull JsonElement jsonElement, @Nonnull Class
      * @return                the deserialized item from the input string
      */
     @Nullable
-    <T> T deserializeObject(@Nonnull JsonElement jsonElement, @Nonnull Class<T> clazz, @Nonnull Map<String, List<String>> responseHeaders);
+    <T> T deserializeObject(@Nonnull final JsonElement jsonElement, @Nonnull final Class<T> clazz, @Nullable final Map<String, List<String>> responseHeaders);
 
     /**
      * Serializes an object into a string