Suppress FB Warnings on Tests, Make some Exceptions Explicit

Author: ramsessanchez

src/main/java/com/microsoft/graph/http/IStatefulResponseHandler.java

@@ -25,9 +25,11 @@
 
 import com.microsoft.graph.logger.ILogger;
 import com.microsoft.graph.serializer.ISerializer;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
 import javax.annotation.Nullable;
 import javax.annotation.Nonnull;
+import java.io.IOException;
 
 /**
  * The handler interface for requests having stateful response from server.
@@ -47,11 +49,13 @@ public interface IStatefulResponseHandler<ResultType, DeserializedType> {
      * @param logger     the logger
      * @param <ResponseType> the native http client response type
      * @return           the result generated by this handler
-     * @throws Exception an exception occurs if the request was unable to complete for any reason
+     * @throws IOException an exception occurs if the request was unable to complete for any reason
+     * @throws GraphServiceException an exception is there is an interruption related to the GraphService
      */
     @Nullable
+    @SuppressFBWarnings
     <ResponseType> ResultType generateResult(@Nonnull final IHttpRequest request,
                               @Nonnull final ResponseType response,
                               @Nonnull final ISerializer serializer,
-                              @Nonnull final ILogger logger) throws Exception;
+                              @Nonnull final ILogger logger) throws IOException, GraphServiceException;
 }

src/main/java/com/microsoft/graph/tasks/LargeFileUploadResponseHandler.java

@@ -76,7 +76,7 @@ public <ResponseType> LargeFileUploadResponse<UploadType> generateResult(
 			@Nonnull final IHttpRequest request,
 			@Nonnull final ResponseType response,
 			@Nonnull final ISerializer serializer,
-			@Nonnull final ILogger logger) throws Exception {
+			@Nonnull final ILogger logger) throws IOException, GraphServiceException {
         Objects.requireNonNull(request, "parameter request cannot be null");
         Objects.requireNonNull(response, "parameter response cannot be null");
         Objects.requireNonNull(serializer, "parameter serializer cannot be null");

src/main/java/com/microsoft/graph/tasks/LargeFileUploadTask.java

@@ -24,6 +24,8 @@
 
 import com.microsoft.graph.core.ClientException;
 import com.microsoft.graph.core.IBaseClient;
+import com.microsoft.graph.http.GraphFatalServiceException;
+import com.microsoft.graph.http.GraphServiceException;
 import com.microsoft.graph.options.Option;
 
 import java.io.IOException;
@@ -98,12 +100,13 @@ public class LargeFileUploadTask<UploadType> {
      * @param inputStream     the input stream
      * @param streamSize      the stream size
      * @param uploadTypeClass the upload type class
+     * @throws GraphServiceException if there is an interruption in the service
      */
     public LargeFileUploadTask(@Nonnull final IUploadSession uploadSession,
                                  @Nonnull final IBaseClient<?> client,
                                  @Nonnull final InputStream inputStream,
                                  final long streamSize,
-                                 @Nonnull final Class<UploadType> uploadTypeClass) {
+                                 @Nonnull final Class<UploadType> uploadTypeClass) throws GraphServiceException {
         Objects.requireNonNull(uploadSession, "Upload session is null.");
 
         if (streamSize <= 0) {

src/test/java/com/microsoft/graph/authentication/TokenCredentialAuthProviderTest.java

@@ -3,6 +3,7 @@
 import com.azure.core.credential.TokenCredential;
 import com.microsoft.graph.mocks.MockTokenCredential;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import org.junit.jupiter.api.Test;
 
 import static org.junit.jupiter.api.Assertions.*;
@@ -13,6 +14,7 @@
 import java.util.ArrayList;
 import java.util.concurrent.ExecutionException;
 
+@SuppressFBWarnings
 public class TokenCredentialAuthProviderTest {
 
     private static final String testToken = "CredentialTestToken";

src/test/java/com/microsoft/graph/content/BatchRequestContentTest.java

@@ -29,6 +29,7 @@
 import com.microsoft.graph.serializer.IJsonBackedObject;
 import com.microsoft.graph.serializer.ISerializer;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.ValueSource;
@@ -41,6 +42,7 @@
 import okhttp3.Response;
 import okhttp3.ResponseBody;
 
+@SuppressFBWarnings
 class BatchRequestContentTest {
 
     String testurl = "http://graph.microsoft.com/v1.0/me";

src/test/java/com/microsoft/graph/content/BatchResponseContentTest.java

@@ -20,8 +20,10 @@
 import com.microsoft.graph.serializer.DefaultSerializer;
 import com.microsoft.graph.serializer.ISerializer;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import org.junit.jupiter.api.Test;
 
+@SuppressFBWarnings
 public class BatchResponseContentTest {
     @Test
     public void testValidBatchResponseContent() {

src/test/java/com/microsoft/graph/core/BaseClientTests.java

@@ -38,7 +38,7 @@ public class BaseClientTests {
     private ISerializer mSerializer;
 
 	@BeforeEach
-	public void setUp() throws Exception {
+	public void setUp() {
         baseClient = new BaseClient<>();
         mLogger = mock(ILogger.class);
         mSerializer = mock(ISerializer.class);

src/test/java/com/microsoft/graph/core/ClientExceptionTests.java

@@ -12,7 +12,7 @@ public class ClientExceptionTests {
     private String expectMessage = "This is test exception message";
 
 	@BeforeEach
-	public void setUp() throws Exception {
+	public void setUp() {
         clientException = new ClientException(expectMessage, null);
 	}
 

src/test/java/com/microsoft/graph/core/GraphServiceClientTest.java

@@ -12,6 +12,7 @@
 import java.util.Map;
 import java.util.concurrent.CompletableFuture;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import org.junit.jupiter.api.Test;
 
 import okhttp3.Request;
@@ -28,6 +29,7 @@
 
 import javax.annotation.Nullable;
 
+@SuppressFBWarnings
 public class GraphServiceClientTest {
     private IAuthenticationProvider getAuthProvider() {
         return mock(IAuthenticationProvider.class);

src/test/java/com/microsoft/graph/http/BaseCollectionPageTests.java

@@ -26,7 +26,7 @@ public class BaseCollectionPageTests {
 
     @BeforeEach
     @SuppressWarnings("unchecked")
-    public void setUp() throws Exception {
+    public void setUp() {
         list = new ArrayList<String>();
         list.add("Object1");
         list.add("Object2");