Skip to content

Commit ae3ced1

Browse files
committed
Give meaningful names to test methods in test classes.
1 parent 05ab9f4 commit ae3ced1

File tree

3 files changed

+11
-14
lines changed

3 files changed

+11
-14
lines changed

src/test/java/com/microsoft/graph/content/MSBatchRequestContentTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public void testRemoveBatchRequesStepWithId() {
6969
}
7070

7171
@Test
72-
public void testRemoveBatchRequesStepWithId1() {
72+
public void testRemoveBatchRequesStepWithIdByAddingMultipleBatchSteps() {
7373
HttpRequest request = new HttpGet(testurl);
7474
List<String> arrayOfDependsOnIds = new ArrayList<>();
7575
MSBatchRequestStep requestStep = new MSBatchRequestStep("1", request, arrayOfDependsOnIds);

src/test/java/com/microsoft/graph/content/MSBatchResponseContentTest.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,23 +31,20 @@ public void testValidMSBatchResponseContent() {
3131
}
3232

3333
@Test
34-
public void testInvalidMSBatchResponseContent() {
35-
//passing empty responses
34+
public void testInvalidMSBatchResponseContentWithEmptyResponse() {
3635
String responsedata = "{\"responses\": [] }";
3736
MSBatchResponseContent batchresponse = new MSBatchResponseContent(responsedata);
3837
assertTrue(batchresponse.getResponseById("1") == null);
3938
}
4039

4140
@Test
42-
public void testInvalidMSBatchResponseContent1() {
43-
//passing null response json string
41+
public void testInvalidMSBatchResponseContentWithNullResponseString() {
4442
MSBatchResponseContent batchresponse = new MSBatchResponseContent(null);
4543
assertTrue(batchresponse.getResponseById("1") == null);
4644
}
4745

4846
@Test
49-
public void testInvalidMSBatchResponseContent2() {
50-
//passing malformed json response
47+
public void testInvalidMSBatchResponseContentWithMalformedResponse() {
5148
String invalidResponsedata = "{responses: [] }";
5249
MSBatchResponseContent batchresponse = new MSBatchResponseContent(invalidResponsedata);
5350
assertTrue(batchresponse.getResponses() == null);

src/test/java/com/microsoft/graph/httpcore/RedirectHandlerTest.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public class RedirectHandlerTest {
2323
String differenthosturl = "https://graph.abc.com/v1.0/";
2424

2525
@Test
26-
public void testIsRedirectedFailure() {
26+
public void testIsRedirectedFailureByNoLocationHeader() {
2727
RedirectHandler redirectHandler = RedirectHandler.INSTANCE;
2828
HttpGet httpget = new HttpGet(testmeurl);
2929
HttpResponse response = new BasicHttpResponse(HttpVersion.HTTP_1_1, HttpStatus.SC_MOVED_TEMPORARILY, "Moved Temporarily");
@@ -38,7 +38,7 @@ public void testIsRedirectedFailure() {
3838
}
3939

4040
@Test
41-
public void testIsRedirectedFailure1() {
41+
public void testIsRedirectedFailureByStatusCodeBadRequest() {
4242
RedirectHandler redirectHandler = RedirectHandler.INSTANCE;
4343
HttpGet httpget = new HttpGet(testmeurl);
4444
HttpResponse response = new BasicHttpResponse(HttpVersion.HTTP_1_1, HttpStatus.SC_BAD_REQUEST, "Bad Request");
@@ -54,7 +54,7 @@ public void testIsRedirectedFailure1() {
5454
}
5555

5656
@Test
57-
public void testIsRedirectedSuccess() {
57+
public void testIsRedirectedSuccessWithStatusCodeMovedTemporarily() {
5858
RedirectHandler redirectHandler = RedirectHandler.INSTANCE;
5959
HttpGet httpget = new HttpGet(testmeurl);
6060
HttpResponse response = new BasicHttpResponse(HttpVersion.HTTP_1_1, HttpStatus.SC_MOVED_TEMPORARILY, "Moved Temporarily");
@@ -70,7 +70,7 @@ public void testIsRedirectedSuccess() {
7070
}
7171

7272
@Test
73-
public void testIsRedirectedSuccess1() {
73+
public void testIsRedirectedSuccessWithStatusCodeMovedPermanently() {
7474
RedirectHandler redirectHandler = RedirectHandler.INSTANCE;
7575
HttpGet httpget = new HttpGet(testmeurl);
7676
HttpResponse response = new BasicHttpResponse(HttpVersion.HTTP_1_1, HttpStatus.SC_MOVED_PERMANENTLY, "Moved Permanently");
@@ -86,7 +86,7 @@ public void testIsRedirectedSuccess1() {
8686
}
8787

8888
@Test
89-
public void testIsRedirectedSuccess2() {
89+
public void testIsRedirectedSuccessWithStatusCodeTemporaryRedirect() {
9090
RedirectHandler redirectHandler = RedirectHandler.INSTANCE;
9191
HttpGet httpget = new HttpGet(testmeurl);
9292
HttpResponse response = new BasicHttpResponse(HttpVersion.HTTP_1_1, HttpStatus.SC_TEMPORARY_REDIRECT, "Temporary Redirect");
@@ -102,7 +102,7 @@ public void testIsRedirectedSuccess2() {
102102
}
103103

104104
@Test
105-
public void testIsRedirectedSuccess3() {
105+
public void testIsRedirectedSuccessWithStatusCodeSeeOther() {
106106
RedirectHandler redirectHandler = RedirectHandler.INSTANCE;
107107
HttpGet httpget = new HttpGet(testmeurl);
108108
HttpResponse response = new BasicHttpResponse(HttpVersion.HTTP_1_1, HttpStatus.SC_SEE_OTHER, "See Other");
@@ -193,7 +193,7 @@ public void testGetRedirectForPostMethod() {
193193
}
194194

195195
@Test
196-
public void testGetRedirectForPostMethod1() {
196+
public void testGetRedirectForPostMethodWithStatusCodeSeeOther() {
197197
RedirectHandler redirectHandler = RedirectHandler.INSTANCE;
198198
HttpPost httppost = new HttpPost(testurl);
199199
HttpResponse response = new BasicHttpResponse(HttpVersion.HTTP_1_1, HttpStatus.SC_SEE_OTHER, "See Other");

0 commit comments

Comments
 (0)