Updating test files for middlewares and HttpClient

Author: deepak2016

src/main/java/com/microsoft/graph/httpcore/HttpClients.java

@@ -17,19 +17,6 @@ public static HttpClientBuilder custom() {
         return HttpClientBuilder.create();
     }
 
-    /**
-     * Creates {@link CloseableHttpClient} instance with default
-     * configuration.
-     */
-    public static CloseableHttpClient createDefault() {
-    	RequestConfig config = RequestConfig.custom().setMaxRedirects(5).build();
-    	return HttpClientBuilder.create().addInterceptorFirst(new AuthenticationHandler(null))
-    			.setRedirectStrategy(new RedirectHandler())
-    			.setServiceUnavailableRetryStrategy(new RetryHandler())
-    			.setDefaultRequestConfig(config)
-    			.build();
-    }
-    
     /**
      * Creates {@link CloseableHttpClient} instance with default
      * configuration and provided authProvider

src/test/java/com/microsoft/graph/httpcore/AuthenticationHandlerTest.java

@@ -21,7 +21,6 @@ public static String getToken() {
 			return "Bearer " + token;
 		}
 		public void authenticateRequest(HttpRequest request) {
-			// TODO Auto-generated method stub
 			request.addHeader("Authorization", AuthProvider.getToken());
 		}
 	}
@@ -38,7 +37,6 @@ public void testAuthenticationHandler() {
 			Header header = httpget.getFirstHeader("Authorization");
 			assertTrue(header.getValue().equals("Bearer " + token));
 		} catch (HttpException | IOException e) {
-			// TODO Auto-generated catch block
 			e.printStackTrace();
 			fail("Authentication handler failure");
 		}

src/test/java/com/microsoft/graph/httpcore/HttpClientsTest.java

@@ -0,0 +1,23 @@
+package com.microsoft.graph.httpcore;
+
+import static org.junit.Assert.assertTrue;
+
+import org.apache.http.HttpRequest;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.junit.Test;
+
+public class HttpClientsTest {
+
+	@Test
+	public void testHttpClientCreation() {
+		IAuthenticationProvider authprovider = new IAuthenticationProvider() {
+			@Override
+			public void authenticateRequest(HttpRequest request) {
+				request.addHeader("Authorization", "TOKEN");
+			}
+		};
+		CloseableHttpClient httpclient = HttpClients.createDefault(authprovider);
+		assertTrue(httpclient != null);
+	}
+
+}

src/test/java/com/microsoft/graph/httpcore/RedirectHandlerTest.java

@@ -13,10 +13,6 @@
 import org.apache.http.client.methods.HttpPost;
 import org.apache.http.client.protocol.HttpClientContext;
 import org.apache.http.message.BasicHttpResponse;
-import org.junit.After;
-import org.junit.AfterClass;
-import org.junit.Before;
-import org.junit.BeforeClass;
 import org.junit.Test;
 
 public class RedirectHandlerTest {
@@ -31,7 +27,6 @@ public void testIsRedirectedFailure() {
 			boolean isRedirected = redirectHandler.isRedirected(httpget, response, localContext);
 			assertTrue(!isRedirected);
 		} catch (ProtocolException e) {
-			// TODO Auto-generated catch block
 			e.printStackTrace();
 			fail("Redirect handler isRedirect failure");
 		}
@@ -47,7 +42,6 @@ public void testIsRedirectedFailure1() {
 			boolean isRedirected = redirectHandler.isRedirected(httpget, response, localContext);
 			assertTrue(!isRedirected);
 		} catch (ProtocolException e) {
-			// TODO Auto-generated catch block
 			e.printStackTrace();
 			fail("Redirect handler isRedirect failure");
 		}
@@ -64,7 +58,6 @@ public void testIsRedirectedSuccess() {
 			boolean isRedirected = redirectHandler.isRedirected(httpget, response, localContext);
 			assertTrue(isRedirected);
 		} catch (ProtocolException e) {
-			// TODO Auto-generated catch block
 			e.printStackTrace();
 			fail("Redirect handler isRedirect failure");
 		}
@@ -83,7 +76,6 @@ public void testGetRedirectForGetMethod() {
 			final String method = request.getRequestLine().getMethod();
 			assertTrue(method.equalsIgnoreCase(HttpGet.METHOD_NAME));
 		} catch (ProtocolException e) {
-			// TODO Auto-generated catch block
 			e.printStackTrace();
 			fail("Redirect handler isRedirect failure");
 		}
@@ -102,7 +94,6 @@ public void testGetRedirectForHeadMethod() {
 			final String method = request.getRequestLine().getMethod();
 			assertTrue(method.equalsIgnoreCase(HttpHead.METHOD_NAME));
 		} catch (ProtocolException e) {
-			// TODO Auto-generated catch block
 			e.printStackTrace();
 			fail("Redirect handler isRedirect failure");
 		}
@@ -140,7 +131,6 @@ public void testGetRedirectForPostMethod1() {
 			final String method = request.getRequestLine().getMethod();
 			assertTrue(method.equalsIgnoreCase(HttpGet.METHOD_NAME));
 		} catch (ProtocolException e) {
-			// TODO Auto-generated catch block
 			e.printStackTrace();
 			fail("Redirect handler isRedirect failure");
 		}