- code-linting: replaces multiple tests by paramaterized

Author: baywet

gradle/dependencies.gradle

@@ -1,6 +1,7 @@
 dependencies {
     // Use JUnit test framework
     testImplementation 'org.junit.jupiter:junit-jupiter-api:5.8.1'
+    testImplementation 'org.junit.jupiter:junit-jupiter-params:5.8.1'
     testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.8.1'
     testImplementation 'org.mockito:mockito-inline:4.0.0'
 

pom.xml

@@ -43,6 +43,12 @@
             <version>5.8.1</version>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>org.junit.jupiter</groupId>
+            <artifactId>junit-jupiter-params</artifactId>
+            <version>5.8.1</version>
+            <scope>test</scope>
+        </dependency>
         <dependency>
             <groupId>org.mockito</groupId>
             <artifactId>mockito-inline</artifactId>

src/test/java/com/microsoft/graph/content/BatchRequestContentTest.java

@@ -30,6 +30,8 @@
 import com.microsoft.graph.serializer.ISerializer;
 
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.ValueSource;
 
 import okhttp3.Call;
 import okhttp3.MediaType;
@@ -66,39 +68,11 @@ void testGetBatchRequestContent() throws MalformedURLException {
         assertEquals(expectedContent, content);
     }
 
-    @Test
-    void testItReplacesChinaHost() throws MalformedURLException {
-        IHttpRequest requestStep = mock(IHttpRequest.class);
-        when(requestStep.getRequestUrl()).thenReturn(new URL("https://microsoftgraph.chinacloudapi.cn/v1.0/me"));
-        BatchRequestContent requestContent = new BatchRequestContent();
-        requestContent.addBatchRequestStep(requestStep);
-        var step = requestContent.requests.get(0);
-        assertEquals("/me", step.url);
-    }
-
-    @Test
-    void testItReplacesGCCHost() throws MalformedURLException {
-        IHttpRequest requestStep = mock(IHttpRequest.class);
-        when(requestStep.getRequestUrl()).thenReturn(new URL("https://graph.microsoft.us/v1.0/me"));
-        BatchRequestContent requestContent = new BatchRequestContent();
-        requestContent.addBatchRequestStep(requestStep);
-        var step = requestContent.requests.get(0);
-        assertEquals("/me", step.url);
-    }
-
-    @Test
-    void testItReplacesDODHost() throws MalformedURLException {
-        IHttpRequest requestStep = mock(IHttpRequest.class);
-        when(requestStep.getRequestUrl()).thenReturn(new URL("https://dod-graph.microsoft.us/v1.0/me"));
-        BatchRequestContent requestContent = new BatchRequestContent();
-        requestContent.addBatchRequestStep(requestStep);
-        var step = requestContent.requests.get(0);
-        assertEquals("/me", step.url);
-    }
-    @Test
-    void testItReplacesGermanHost() throws MalformedURLException {
+    @ParameterizedTest
+    @ValueSource(strings = { "https://microsoftgraph.chinacloudapi.cn/v1.0/me", "https://graph.microsoft.com/v1.0/me", "https://graph.microsoft.us/v1.0/me", "https://dod-graph.microsoft.us/v1.0/me", "https://graph.microsoft.de/v1.0/me"})
+    void testItReplacesNationalHost(final String url) throws MalformedURLException {
         IHttpRequest requestStep = mock(IHttpRequest.class);
-        when(requestStep.getRequestUrl()).thenReturn(new URL("https://graph.microsoft.de/v1.0/me"));
+        when(requestStep.getRequestUrl()).thenReturn(new URL(url));
         BatchRequestContent requestContent = new BatchRequestContent();
         requestContent.addBatchRequestStep(requestStep);
         var step = requestContent.requests.get(0);