- fixes a bug where the SDK would be expecting a different casing tahn the service for error codes

Author: baywet

src/main/java/com/microsoft/graph/http/GraphError.java

@@ -26,6 +26,7 @@
 
 import com.microsoft.graph.core.GraphErrorCodes;
 import com.google.gson.annotations.Expose;
+import com.google.common.base.CaseFormat;
 
 public class GraphError {
 
@@ -47,16 +48,24 @@ public class GraphError {
      * @return <b>true</b> if the error code matches, and <b>false</b> if there was no match
      */
     public boolean isError(final GraphErrorCodes expectedCode) {
-        if (code.equalsIgnoreCase(expectedCode.toString())) {
+        if (transformErrorCodeCase(code).equalsIgnoreCase(expectedCode.toString())) {
             return true;
         }
         GraphInnerError innerError = innererror;
         while (null != innerError) {
-            if (innerError.code.equalsIgnoreCase(expectedCode.toString())) {
+            if (transformErrorCodeCase(innerError.code).equalsIgnoreCase(expectedCode.toString())) {
                 return true;
             }
             innerError = innerError.innererror;
         }
         return false;
     }
+    /**
+     * Transforms the text error code into the format expected by the value of the enum
+     * @param original original lowser Camel cased error code
+     * @return the resulting upper undescore cased error code
+     */
+    protected String transformErrorCodeCase(final String original) {
+        return CaseFormat.LOWER_CAMEL.to(CaseFormat.UPPER_UNDERSCORE, original);
+    }
 }

src/test/java/com/microsoft/graph/http/GraphErrorTests.java

@@ -15,7 +15,7 @@ public class GraphErrorTests {
 	public void testIsError(){
         String expectedMessage = "test error message";
         GraphError error = new GraphError();
-        error.code = GraphErrorCodes.ACCESS_DENIED.toString();
+        error.code = "accessDenied"; // the code prop is lower camel cased https://docs.microsoft.com/en-us/graph/errors#code-property
         error.message = expectedMessage;
         assertTrue(error.isError(GraphErrorCodes.ACCESS_DENIED));
         assertEquals(expectedMessage, error.message);