Skip to content

Commit 33b384d

Browse files
author
Caitlin Bales (MSFT)
committed
Add missing parameters on handwritten core files
1 parent ef733c5 commit 33b384d

File tree

7 files changed

+15
-11
lines changed

7 files changed

+15
-11
lines changed

src/main/java/com/microsoft/graph/http/CustomRequest.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ public void delete() throws ClientException {{
6565

6666
/**
6767
* Patches this item with a source
68-
* @param sourceItem The source object with updates
6968
* @param callback The callback to be called after success or failure.
7069
*/
7170
public void patch(final ICallback<T> callback) {
@@ -74,7 +73,7 @@ public void patch(final ICallback<T> callback) {
7473

7574
/**
7675
* Patches this item with a source
77-
* @param sourceAttachment The source object with updates
76+
* @param sourceObject The source object with updates
7877
* @return The updated item
7978
* @throws ClientException This exception occurs if the request was unable to complete for any reason.
8079
*/
@@ -84,7 +83,7 @@ public T patch(final T sourceObject) throws ClientException {
8483

8584
/**
8685
* Creates a new object
87-
* @param newAttachment The new object to create
86+
* @param newObject The new object to create
8887
* @param callback The callback to be called after success or failure.
8988
*/
9089
public void post(final T newObject, final ICallback<T> callback) {
@@ -93,8 +92,8 @@ public void post(final T newObject, final ICallback<T> callback) {
9392

9493
/**
9594
* Creates a new object
96-
* @param newAttachment The new object to create
97-
* @return The created Attachment
95+
* @param newObject The new object to create
96+
* @return The created object
9897
* @throws ClientException This exception occurs if the request was unable to complete for any reason.
9998
*/
10099
public T post(final T newObject) throws ClientException {

src/main/java/com/microsoft/graph/http/GraphFatalServiceException.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ public class GraphFatalServiceException extends GraphServiceException {
4141
* @param responseMessage The response message.
4242
* @param responseHeaders The response headers.
4343
* @param error The error response if available.
44+
* @param verbose Whether or not to log verbosely.
4445
*/
4546
protected GraphFatalServiceException(final String method,
4647
final String url,

src/main/java/com/microsoft/graph/http/GraphServiceException.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -237,6 +237,7 @@ public GraphError getServiceError() {
237237
* @param serializable The serialized object that was sent with this request.
238238
* @param serializer The serializer to re-create the option in its over the wire state.
239239
* @param connection The connection that was used to extract the response information from.
240+
* @param logger The logger to log exception information to.
240241
* @param <T> The type of the serializable object.
241242
* @return The new GraphServiceException instance.
242243
* @throws IOException An exception occurs if there were any problems processing the connection.

src/main/java/com/microsoft/graph/requests/extensions/GraphServiceClient.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@ public CustomRequestBuilder customRequest(final String url, final Class response
4545
}
4646

4747
/**
48-
* end a custom request to Graph
49-
* @param url THe full URL to make a request with
48+
* Send a custom request to Graph
49+
* @param url The full URL to make a request with
5050
* @return the instance of this builder
5151
*/
5252
public CustomRequestBuilder customRequest(final String url) {
@@ -137,6 +137,7 @@ public Builder fromConfig(final IClientConfig clientConfig) {
137137
/**
138138
* Builds and returns the GraphServiceClient
139139
* @throws ClientException if there was an exception creating the client
140+
* @return The GraphServiceClient object
140141
*/
141142
public IGraphServiceClient buildClient() throws ClientException {
142143
client.validate();

src/main/java/com/microsoft/graph/serializer/FallBackEnumTypeAdapter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public class FallBackEnumTypeAdapter implements TypeAdapterFactory {
5858
*
5959
* @param gson GSON
6060
* @param type The type.
61-
* @return <T> The type adapter
61+
* @return The type adapter
6262
*/
6363
public <T> TypeAdapter<T> create(final Gson gson, final TypeToken<T> type) {
6464
//no inspection unchecked

src/main/java/com/microsoft/graph/serializer/IJsonBackedObject.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ public interface IJsonBackedObject {
4040
/**
4141
* Provides access to objects not anticipated in the model, as well as
4242
* request and response data from the HTTP call
43+
* @return The AddtionalDataManager
4344
*/
4445
AdditionalDataManager additionalDataManager();
4546

src/main/java/com/microsoft/graph/serializer/ISerializer.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,10 @@ public interface ISerializer {
4141

4242
/**
4343
* Deserialize an object from the input string.
44-
* @param inputString The string that stores the representation of the item.
45-
* @param clazz The .class of the item to be deserialized.
46-
* @param <T> The type of the item to be deserialized.
44+
* @param inputString The string that stores the representation of the item.
45+
* @param clazz The .class of the item to be deserialized.
46+
* @param responseHeaders The HTTP response headers.
47+
* @param <T> The type of the item to be deserialized.
4748
* @return The deserialized item from the input string.
4849
*/
4950
<T> T deserializeObject(final String inputString, Class<T> clazz, Map<String, List<String>> responseHeaders);

0 commit comments

Comments
 (0)