Skip to content

Commit 4246dc8

Browse files
author
Nakul Sabharwal
committed
Edited comments for javadoc
1 parent 697e3ef commit 4246dc8

File tree

5 files changed

+10
-9
lines changed

5 files changed

+10
-9
lines changed

src/main/java/com/microsoft/graph/core/DefaultConnectionConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ public IShouldRetry getShouldRetry() {
161161
/**
162162
* Sets the max retries
163163
*
164-
* @param Max retries for a request
164+
* @param maxRetries Max retries for a request
165165
*/
166166
public void setMaxRetries(int maxRetries) {
167167
this.maxRedirects = maxRedirects;

src/main/java/com/microsoft/graph/core/IConnectionConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ public interface IConnectionConfig {
100100
/**
101101
* Sets the max retries
102102
*
103-
* @param Max retries for a request
103+
* @param maxRetries Max retries for a request
104104
*/
105105
void setMaxRetries(int maxRetries);
106106

src/main/java/com/microsoft/graph/http/IStatefulResponseHandler.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public interface IStatefulResponseHandler<ResultType, DeserializedType> {
4949
*
5050
* @param response the HTTP response
5151
*/
52-
void configConnection(final Response connection);
52+
void configConnection(final Response response);
5353

5454
/**
5555
* Generate result after receiving response
@@ -70,7 +70,7 @@ ResultType generateResult(final IHttpRequest request,
7070
* Generate result after receiving response
7171
*
7272
* @param request the HTTP request
73-
* @param connection the HTTP connection
73+
* @param response the HTTP connection
7474
* @param serializer the serializer for parsing response
7575
* @param logger the logger
7676
* @return the result generated by this handler

src/main/java/com/microsoft/graph/http/OkHttpProvider.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ public Request authenticateRequest(Request request) {
282282
}
283283
});
284284

285-
Interceptor[] interceptors = {redirectHandler, retryHandler, authenticationHandler};
285+
Interceptor[] interceptors = {authenticationHandler, redirectHandler, retryHandler};
286286
OkHttpClient.Builder okBuilder = HttpClients.createFromInterceptors(interceptors).newBuilder();
287287
okBuilder.connectTimeout(connectionConfig.getConnectTimeout(), TimeUnit.MILLISECONDS);
288288
okBuilder.readTimeout(connectionConfig.getReadTimeout(), TimeUnit.MILLISECONDS);

src/test/java/com/microsoft/graph/requests/extensions/GraphServiceClientTest.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import com.microsoft.graph.http.IHttpProvider;
2323
import com.microsoft.graph.http.IHttpRequest;
2424
import com.microsoft.graph.http.IStatefulResponseHandler;
25+
import com.microsoft.graph.http.OkHttpProvider;
2526
import com.microsoft.graph.logger.ILogger;
2627
import com.microsoft.graph.logger.LoggerLevel;
2728
import com.microsoft.graph.models.extensions.IGraphServiceClient;
@@ -61,7 +62,7 @@ public void testOverrideOfDefaultLogger() {
6162
assertNotNull(client.getHttpProvider());
6263
assertNotNull(client.getLogger());
6364
assertNotNull(client.getSerializer());
64-
assertEquals(logger, ((DefaultHttpProvider) client.getHttpProvider()).getLogger());
65+
assertEquals(logger, ((OkHttpProvider) client.getHttpProvider()).getLogger());
6566
assertEquals(logger, ((DefaultSerializer) client.getSerializer()).getLogger());
6667
assertEquals(logger, ((DefaultExecutors) client.getExecutors()).getLogger());
6768
assertEquals(logger, client.getLogger());
@@ -85,7 +86,7 @@ public void authenticateRequest(IHttpRequest request) {
8586
assertNotNull(client.getLogger());
8687
assertNotNull(client.getSerializer());
8788
assertEquals(ap,
88-
((DefaultHttpProvider) client.getHttpProvider()).getAuthenticationProvider());
89+
((OkHttpProvider) client.getHttpProvider()).getAuthenticationProvider());
8990
}
9091

9192
@Test
@@ -129,7 +130,7 @@ public void shutdownBackgroundExecutors() {
129130
assertNotNull(client.getHttpProvider());
130131
assertNotNull(client.getLogger());
131132
assertNotNull(client.getSerializer());
132-
assertEquals(ex, ((DefaultHttpProvider) client.getHttpProvider()).getExecutors());
133+
assertEquals(ex, ((OkHttpProvider) client.getHttpProvider()).getExecutors());
133134
}
134135

135136
@Test
@@ -161,7 +162,7 @@ public <T> T deserializeObject(String inputString, Class<T> clazz) {
161162
assertNotNull(client.getHttpProvider());
162163
assertNotNull(client.getLogger());
163164
assertNotNull(client.getExecutors());
164-
assertEquals(serializer, ((DefaultHttpProvider) client.getHttpProvider()).getSerializer());
165+
assertEquals(serializer, ((OkHttpProvider) client.getHttpProvider()).getSerializer());
165166
}
166167

167168
@Test

0 commit comments

Comments
 (0)