Merge pull request #38 from davidmoten/fix-default-config

DefaultClientConfig override fix

Author: Caitlin Bales (MSFT)

src/main/java/com/microsoft/graph/core/DefaultClientConfig.java

@@ -106,7 +106,7 @@ public IHttpProvider getHttpProvider() {
                     getAuthenticationProvider(),
                     getExecutors(),
                     getLogger());
-            logger.logDebug("Created DefaultHttpProvider");
+            getLogger().logDebug("Created DefaultHttpProvider");
         }
         return httpProvider;
     }
@@ -120,7 +120,7 @@ public IHttpProvider getHttpProvider() {
     public ISerializer getSerializer() {
         if (serializer == null) {
             serializer = new DefaultSerializer(getLogger());
-            logger.logDebug("Created DefaultSerializer");
+            getLogger().logDebug("Created DefaultSerializer");
         }
         return serializer;
     }
@@ -134,7 +134,7 @@ public ISerializer getSerializer() {
     public IExecutors getExecutors() {
         if (executors == null) {
             executors = new DefaultExecutors(getLogger());
-            logger.logDebug("Created DefaultExecutors");
+            getLogger().logDebug("Created DefaultExecutors");
         }
         return executors;
     }

src/test/java/com/microsoft/graph/core/DefaultClientConfigTests.java

@@ -10,6 +10,8 @@
 
 import com.microsoft.graph.authentication.IAuthenticationProvider;
 import com.microsoft.graph.authentication.MockAuthenticationProvider;
+import com.microsoft.graph.logger.DefaultLogger;
+import com.microsoft.graph.logger.ILogger;
 
 /**
  * Test cases for {@see DefaultClientConfig}
@@ -36,5 +38,23 @@ public void testDefaultClientConfig() {
         assertNotNull(mClientConfig.getAuthenticationProvider());
         assertEquals(mAuthenticationProvider, mClientConfig.getAuthenticationProvider());
     }
+	
+    @Test
+    public void testOverrideLoggerShouldNotThrow() {
+        final ILogger logger = new DefaultLogger();
+        DefaultClientConfig config = new DefaultClientConfig() {
+
+            @Override
+            public ILogger getLogger() {
+                return logger;
+            }
+
+        };
+        config.getExecutors();
+        config.getAuthenticationProvider();
+        config.getHttpProvider();
+        config.getSerializer();
+        config.getLogger();
+    }
 
 }