Skip to content

Commit 4cecee1

Browse files
author
Caitlin Bales (MSFT)
committed
Add parameters to tests
1 parent 9c356b1 commit 4cecee1

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

src/test/java/com/microsoft/graph/http/BaseCollectionPageTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public class BaseCollectionPageTests {
2020

2121
private IRequestBuilder mRequestBuilder;
2222
private static ArrayList<String> list;
23-
private BaseCollectionPage baseCollectionPage;
23+
private BaseCollectionPage<String, IRequestBuilder> baseCollectionPage;
2424
private String requestUrl = "https://a.b.c";
2525

2626
@Before

src/test/java/com/microsoft/graph/http/BaseCollectionRequestTests.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public class BaseCollectionRequestTests {
2626

2727
private MockAuthenticationProvider mAuthenticationProvider;
2828
private MockBaseClient mBaseClient;
29-
private BaseCollectionRequest request;
29+
private BaseCollectionRequest<JsonObject, String> request;
3030

3131
@Before
3232
public void setUp() throws Exception {
@@ -78,7 +78,7 @@ public void testPost() {
7878
public void testFunctionParameters() {
7979
final Option f1 = new FunctionOption("1", "one");
8080
final Option f2 = new FunctionOption("2", null);
81-
final BaseCollectionRequest request = new BaseCollectionRequest<String,String>("https://a.b.c", null, Arrays.asList(f1, f2), null,null){};
81+
final BaseCollectionRequest<String,String> request = new BaseCollectionRequest<String,String>("https://a.b.c", null, Arrays.asList(f1, f2), null,null){};
8282
String urlTest = request.getRequestUrl().toString();
8383
assertEquals("https://a.b.c(1='one',2=null)", request.getRequestUrl().toString());
8484
request.addFunctionOption(new FunctionOption("3","two"));;
@@ -90,7 +90,7 @@ public void testFunctionParameters() {
9090
public void testQueryParameters() {
9191
final Option q1 = new QueryOption("q1","option1 ");
9292
final Option q2 = new QueryOption("q2","option2");
93-
final BaseCollectionRequest request = new BaseCollectionRequest<String,String>("https://a.b.c", null, Arrays.asList(q1, q2), null,null){};
93+
final BaseCollectionRequest<String,String> request = new BaseCollectionRequest<String,String>("https://a.b.c", null, Arrays.asList(q1, q2), null,null){};
9494
assertEquals("https://a.b.c?q1=option1+&q2=option2", request.getRequestUrl().toString());
9595
request.addQueryOption(new QueryOption("q3","option3"));
9696
assertEquals("https://a.b.c?q1=option1+&q2=option2&q3=option3", request.getRequestUrl().toString());
@@ -103,7 +103,7 @@ public void testFunctionAndQueryParameters() {
103103
final Option f2 = new FunctionOption("f2", null);
104104
final Option q1 = new QueryOption("q1","option1 ");
105105
final Option q2 = new QueryOption("q2","option2");
106-
final BaseCollectionRequest request = new BaseCollectionRequest<String,String>("https://a.b.c", null, Arrays.asList(f1, f2, q1, q2), null,null){};
106+
final BaseCollectionRequest<String,String> request = new BaseCollectionRequest<String,String>("https://a.b.c", null, Arrays.asList(f1, f2, q1, q2), null,null){};
107107
assertEquals("https://a.b.c(f1='fun1',f2=null)?q1=option1+&q2=option2", request.getRequestUrl().toString());
108108
assertEquals(5, request.getOptions().size());
109109
}
@@ -121,7 +121,7 @@ public void testHttpMethod() {
121121
public void testHeader() {
122122
String expectedHeader = "header key";
123123
String expectedValue = "header value";
124-
final BaseCollectionRequest request = new BaseCollectionRequest<String,String>("https://a.b.c", null, null, null,null){};
124+
final BaseCollectionRequest<String,String> request = new BaseCollectionRequest<String,String>("https://a.b.c", null, null, null,null){};
125125
assertEquals(1, request.getHeaders().size());
126126
request.addHeader(expectedHeader,expectedValue);
127127
assertEquals(2,request.getHeaders().size());

src/test/java/com/microsoft/graph/http/BaseStreamRequestTests.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public Map<String, String> getHeaders() {
5858
new MockLogger());
5959
mProvider.setConnectionFactory(new MockConnectionFactory(new MockConnection(data)));
6060
mBaseClient.setHttpProvider(mProvider);
61-
final BaseStreamRequest request = new BaseStreamRequest<String>("https://a.b.c", mBaseClient,null, null){};
61+
final BaseStreamRequest<String> request = new BaseStreamRequest<String>("https://a.b.c", mBaseClient,null, null){};
6262
request.send();
6363
assertEquals(1, mAuthenticationProvider.getInterceptionCount());
6464
}
@@ -102,7 +102,7 @@ public void failure(ClientException ex) {
102102
failure.set(true);
103103
}
104104
};
105-
final BaseStreamRequest request = new BaseStreamRequest<InputStream>("https://a.b.c", mBaseClient,null, InputStream.class){};
105+
final BaseStreamRequest<InputStream> request = new BaseStreamRequest<InputStream>("https://a.b.c", mBaseClient,null, InputStream.class){};
106106
request.send(callback);
107107
assertTrue(success.get());
108108
assertFalse(failure.get());
@@ -148,7 +148,7 @@ public void failure(ClientException ex) {
148148
failure.set(true);
149149
}
150150
};
151-
final BaseStreamRequest request = new BaseStreamRequest<InputStream>("https://a.b.c", mBaseClient,null, InputStream.class){};
151+
final BaseStreamRequest<InputStream> request = new BaseStreamRequest<InputStream>("https://a.b.c", mBaseClient,null, InputStream.class){};
152152
request.send(new byte[]{1, 2, 3, 4},callback);
153153
assertTrue(success.get());
154154
assertFalse(failure.get());
@@ -181,14 +181,14 @@ public Map<String, String> getHeaders() {
181181
new MockLogger());
182182
mProvider.setConnectionFactory(new MockConnectionFactory(new MockConnection(data)));
183183
mBaseClient.setHttpProvider(mProvider);
184-
final BaseStreamRequest request = new BaseStreamRequest<InputStream>("https://a.b.c", mBaseClient,null, InputStream.class){};
184+
final BaseStreamRequest<InputStream> request = new BaseStreamRequest<InputStream>("https://a.b.c", mBaseClient,null, InputStream.class){};
185185
request.send(new byte[]{1, 2, 3, 4});
186186
assertEquals(1, mAuthenticationProvider.getInterceptionCount());
187187
}
188188

189189
@Test
190190
public void testBaseMethod() {
191-
final BaseStreamRequest request = new BaseStreamRequest<InputStream>("https://a.b.c", mBaseClient,null, InputStream.class){};
191+
final BaseStreamRequest<InputStream> request = new BaseStreamRequest<InputStream>("https://a.b.c", mBaseClient,null, InputStream.class){};
192192
assertEquals("https://a.b.c", request.getRequestUrl().toString());
193193
request.addHeader("header key", "header value");
194194
assertEquals(2,request.getHeaders().size());

0 commit comments

Comments
 (0)