Skip to content

Commit 54fa900

Browse files
authored
Apply suggestions from code review
1 parent 696f8a7 commit 54fa900

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/main/java/com/microsoft/graph/http/CoreHttpProvider.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -387,11 +387,11 @@ public Request authenticateRequest(Request request) {
387387
.newBuilder()
388388
.connectTimeout(connectionConfig.getConnectTimeout(), TimeUnit.MILLISECONDS)
389389
.readTimeout(connectionConfig.getReadTimeout(), TimeUnit.MILLISECONDS)
390-
.followRedirects(false) //TODO those are duplicated for the time being with core, remove in 3.0
390+
.followRedirects(false) //TODO https://github.com/microsoftgraph/msgraph-sdk-java/issues/516
391391
.protocols(Arrays.asList(Protocol.HTTP_1_1)) //https://stackoverflow.com/questions/62031298/sockettimeout-on-java-11-but-not-on-java-8
392392
.build();
393393
}
394-
if (authenticationProvider != null) { //TODO remove the authentication provider as this is done by the interceptor anyway
394+
if (authenticationProvider != null) { //TODO https://github.com/microsoftgraph/msgraph-sdk-java/issues/517
395395
authenticationProvider.authenticateRequest(request);
396396
}
397397
Request coreHttpRequest = getHttpRequest(request, resultClass, serializable, progress);

0 commit comments

Comments
 (0)