Skip to content

Commit 6d65b37

Browse files
author
Caitlin Bales (MSFT)
committed
Add etag accessors
1 parent e8ec5ca commit 6d65b37

File tree

8 files changed

+78
-29
lines changed

8 files changed

+78
-29
lines changed

src/main/java/com/microsoft/graph/models/extensions/PlannerAssignedToTaskBoardTaskFormat.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44

55
package com.microsoft.graph.models.extensions;
66

7+
import com.google.gson.annotations.Expose;
8+
import com.google.gson.annotations.SerializedName;
79
import com.microsoft.graph.concurrency.*;
810
import com.microsoft.graph.core.*;
911
import com.microsoft.graph.models.extensions.*;
@@ -25,6 +27,13 @@
2527
public class PlannerAssignedToTaskBoardTaskFormat extends BasePlannerAssignedToTaskBoardTaskFormat {
2628

2729
/**
30+
* The Etag.
31+
*/
32+
@SerializedName("@odata.etag")
33+
@Expose
34+
public String etag;
35+
36+
/**
2837
* The GetOrderHintForAssignee
2938
*/
3039
public String orderHintForAssignee(String userId)

src/main/java/com/microsoft/graph/models/extensions/PlannerBucket.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44

55
package com.microsoft.graph.models.extensions;
66

7+
import com.google.gson.annotations.Expose;
8+
import com.google.gson.annotations.SerializedName;
79
import com.microsoft.graph.concurrency.*;
810
import com.microsoft.graph.core.*;
911
import com.microsoft.graph.models.extensions.*;
@@ -23,5 +25,10 @@
2325
* The class for the Planner Bucket.
2426
*/
2527
public class PlannerBucket extends BasePlannerBucket {
26-
28+
/**
29+
* The Etag.
30+
*/
31+
@SerializedName("@odata.etag")
32+
@Expose
33+
public String etag;
2734
}

src/main/java/com/microsoft/graph/models/extensions/PlannerBucketTaskBoardTaskFormat.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44

55
package com.microsoft.graph.models.extensions;
66

7+
import com.google.gson.annotations.Expose;
8+
import com.google.gson.annotations.SerializedName;
79
import com.microsoft.graph.concurrency.*;
810
import com.microsoft.graph.core.*;
911
import com.microsoft.graph.models.extensions.*;
@@ -24,4 +26,10 @@
2426
*/
2527
public class PlannerBucketTaskBoardTaskFormat extends BasePlannerBucketTaskBoardTaskFormat {
2628

29+
/**
30+
* The Etag.
31+
*/
32+
@SerializedName("@odata.etag")
33+
@Expose
34+
public String etag;
2735
}

src/main/java/com/microsoft/graph/models/extensions/PlannerPlanDetails.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44

55
package com.microsoft.graph.models.extensions;
66

7+
import com.google.gson.annotations.Expose;
8+
import com.google.gson.annotations.SerializedName;
79
import com.microsoft.graph.concurrency.*;
810
import com.microsoft.graph.core.*;
911
import com.microsoft.graph.models.extensions.*;
@@ -24,4 +26,10 @@
2426
*/
2527
public class PlannerPlanDetails extends BasePlannerPlanDetails {
2628

29+
/**
30+
* The Etag.
31+
*/
32+
@SerializedName("@odata.etag")
33+
@Expose
34+
public String etag;
2735
}

src/main/java/com/microsoft/graph/models/extensions/PlannerProgressTaskBoardTaskFormat.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44

55
package com.microsoft.graph.models.extensions;
66

7+
import com.google.gson.annotations.Expose;
8+
import com.google.gson.annotations.SerializedName;
79
import com.microsoft.graph.concurrency.*;
810
import com.microsoft.graph.core.*;
911
import com.microsoft.graph.models.extensions.*;
@@ -24,4 +26,10 @@
2426
*/
2527
public class PlannerProgressTaskBoardTaskFormat extends BasePlannerProgressTaskBoardTaskFormat {
2628

29+
/**
30+
* The Etag.
31+
*/
32+
@SerializedName("@odata.etag")
33+
@Expose
34+
public String etag;
2735
}

src/main/java/com/microsoft/graph/models/extensions/PlannerTask.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44

55
package com.microsoft.graph.models.extensions;
66

7+
import com.google.gson.annotations.Expose;
8+
import com.google.gson.annotations.SerializedName;
79
import com.microsoft.graph.concurrency.*;
810
import com.microsoft.graph.core.*;
911
import com.microsoft.graph.models.extensions.*;
@@ -24,4 +26,10 @@
2426
*/
2527
public class PlannerTask extends BasePlannerTask {
2628

29+
/**
30+
* The Etag.
31+
*/
32+
@SerializedName("@odata.etag")
33+
@Expose
34+
public String etag;
2735
}

src/main/java/com/microsoft/graph/models/extensions/PlannerTaskDetails.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44

55
package com.microsoft.graph.models.extensions;
66

7+
import com.google.gson.annotations.Expose;
8+
import com.google.gson.annotations.SerializedName;
79
import com.microsoft.graph.concurrency.*;
810
import com.microsoft.graph.core.*;
911
import com.microsoft.graph.models.extensions.*;
@@ -24,4 +26,10 @@
2426
*/
2527
public class PlannerTaskDetails extends BasePlannerTaskDetails {
2628

29+
/**
30+
* The Etag.
31+
*/
32+
@SerializedName("@odata.etag")
33+
@Expose
34+
public String etag;
2735
}

src/test/java/com/microsoft/graph/functional/PlannerTests.java

Lines changed: 21 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
import java.util.Calendar;
3737
import java.util.UUID;
3838

39-
@Ignore
39+
//@Ignore
4040
public class PlannerTests {
4141
private static TestBase testBase;
4242
// For now, you must specify a specific plan ID since the test cannot
@@ -65,7 +65,7 @@ public static void setUp() {
6565
planTask = prb.tasks().buildRequest().post(newTask);
6666
}
6767

68-
@Test
68+
//@Test
6969
public void testPostTask() {
7070
PlannerTask newTask = new PlannerTask();
7171
newTask.title = "Test1";
@@ -136,7 +136,7 @@ public void testUpdateTask() throws InterruptedException {
136136
IPlannerTaskRequest req = prb
137137
.tasks(planTask.id)
138138
.buildRequest();
139-
req.addHeader("If-Match", getEtag(planTask.getRawObject()));
139+
req.addHeader("If-Match", planTask.etag);
140140
req.patch(task);
141141

142142
Thread.sleep(4000);
@@ -194,8 +194,8 @@ public void testUpdateTaskDetailsChecklist() throws InterruptedException {
194194
.tasks(planTask.id)
195195
.details()
196196
.buildRequest();
197-
req.addHeader("If-Match", getEtag(d.getRawObject()));
198-
req.addHeader("If-None-Match", getEtag(d.getRawObject()));
197+
req.addHeader("If-Match", d.etag);
198+
req.addHeader("If-None-Match", d.etag);
199199
req.patch(details);
200200

201201
Thread.sleep(4000);
@@ -207,7 +207,7 @@ public void testUpdateTaskDetailsChecklist() throws InterruptedException {
207207
}
208208

209209
// Fails due to delay from service
210-
@Test
210+
@Test
211211
public void testUpdateTaskDetailsReferences() {
212212
try {
213213
PlannerTaskDetails details = new PlannerTaskDetails();
@@ -236,8 +236,8 @@ public void testUpdateTaskDetailsReferences() {
236236
.tasks(planTask.id)
237237
.details()
238238
.buildRequest();
239-
req.addHeader("If-Match", getEtag(d.getRawObject()));
240-
req.addHeader("If-None-Match", getEtag(d.getRawObject()));
239+
req.addHeader("If-Match", d.etag);
240+
req.addHeader("If-None-Match", d.etag);
241241
req.addHeader("Prefer", "return=representation");
242242
PlannerTaskDetails updatedTaskDetails = req.patch(details);
243243

@@ -265,7 +265,7 @@ public void testUpdateTaskCompletion() throws InterruptedException {
265265
task.percentComplete = 50;
266266

267267
IPlannerTaskRequest req = prb.tasks(planTask.id).buildRequest();
268-
req.addHeader("If-Match", getEtag(planTask.getRawObject()));
268+
req.addHeader("If-Match", planTask.etag);
269269
req.patch(task);
270270

271271
Thread.sleep(4000);
@@ -281,7 +281,7 @@ public void testUpdateTaskStartDate() throws InterruptedException {
281281
task.startDateTime = Calendar.getInstance();
282282

283283
IPlannerTaskRequest req = prb.tasks(planTask.id).buildRequest();
284-
req.addHeader("If-Match", getEtag(planTask.getRawObject()));
284+
req.addHeader("If-Match", planTask.etag);
285285
req.patch(task);
286286

287287
Thread.sleep(2000);
@@ -300,7 +300,7 @@ public void testUpdateTaskDueDate() throws InterruptedException {
300300
IPlannerTaskRequest req = prb.tasks(planTask.id).buildRequest();
301301
planTask = prb.tasks(planTask.id).buildRequest().get();
302302

303-
req.addHeader("If-Match", getEtag(planTask.getRawObject()));
303+
req.addHeader("If-Match", planTask.etag);
304304
req.patch(task);
305305

306306
Thread.sleep(6000);
@@ -329,8 +329,8 @@ public void testUpdateTaskCategories() {
329329

330330
PlannerTask newTask = prb.tasks(planTask.id).buildRequest().get();
331331
IPlannerTaskRequest req = prb.tasks(planTask.id).buildRequest();
332-
req.addHeader("If-Match", getEtag(newTask.getRawObject()));
333-
req.addHeader("If-None-Match", getEtag(newTask.getRawObject()));
332+
req.addHeader("If-Match", newTask.etag);
333+
req.addHeader("If-None-Match", newTask.etag);
334334
req.addHeader("Prefer", "return=representation");
335335
PlannerTask updatedTask = req.patch(task);
336336

@@ -348,8 +348,8 @@ public void testUpdatePlanDetails() {
348348

349349
PlannerPlanDetails newDetails = prb.plans(planId).details().buildRequest().get();
350350
IPlannerPlanDetailsRequest req = prb.plans(planId).details().buildRequest();
351-
req.addHeader("If-Match", getEtag(newDetails.getRawObject()));
352-
req.addHeader("If-None-Match", getEtag(newDetails.getRawObject()));
351+
req.addHeader("If-Match", newDetails.etag);
352+
req.addHeader("If-None-Match", newDetails.etag);
353353
req.addHeader("Prefer", "return=representation");
354354
PlannerPlanDetails updatedPlanDetails = req.patch(planDetails);
355355

@@ -366,7 +366,7 @@ public void testDeleteTask() {
366366
PlannerTask task = prb.tasks().buildRequest().post(newTask);
367367

368368
IPlannerTaskRequest req = testBase.graphClient.planner().tasks(task.id).buildRequest();
369-
req.addHeader("If-Match", getEtag(task.getRawObject()));
369+
req.addHeader("If-Match", task.etag);
370370
req.delete();
371371
}
372372

@@ -387,7 +387,7 @@ public void testUpdateBucket() {
387387
patchBucket.oDataType = "#microsoft.graph.plannerBucket";
388388

389389
IPlannerBucketRequest req = prb.buckets(planBucket.id).buildRequest();
390-
req.addHeader("If-Match", getEtag(planBucket.getRawObject()));
390+
req.addHeader("If-Match", planBucket.etag);
391391

392392
req.patch(patchBucket);
393393
PlannerBucket updatedBucket = prb.buckets(planBucket.id).buildRequest().get();
@@ -396,7 +396,7 @@ public void testUpdateBucket() {
396396

397397
patchBucket.name = "Test Bucket";
398398
IPlannerBucketRequest req2 = testBase.graphClient.planner().buckets(planBucket.id).buildRequest();
399-
req2.addHeader("If-Match", getEtag(updatedBucket.getRawObject()));
399+
req2.addHeader("If-Match", updatedBucket.etag);
400400
req2.patch(patchBucket);
401401
}
402402

@@ -409,7 +409,7 @@ public void testDeleteBucket() {
409409
PlannerBucket createdBucket = testBase.graphClient.planner().buckets().buildRequest().post(newBucket);
410410

411411
IPlannerBucketRequest req = testBase.graphClient.planner().buckets(createdBucket.id).buildRequest();
412-
req.addHeader("If-Match", getEtag(createdBucket.getRawObject()));
412+
req.addHeader("If-Match", createdBucket.etag);
413413
req.delete();
414414
}
415415

@@ -421,12 +421,12 @@ public static void tearDown() throws InterruptedException {
421421
//This may have updated since we last saw it
422422
PlannerTask task = testBase.graphClient.planner().tasks(planTask.id).buildRequest().get();
423423
IPlannerTaskRequest taskReq = testBase.graphClient.planner().tasks(planTask.id).buildRequest();
424-
taskReq.addHeader("If-Match", getEtag(task.getRawObject()));
424+
taskReq.addHeader("If-Match", task.etag);
425425
taskReq.delete();
426426

427427
PlannerBucket bucket = testBase.graphClient.planner().buckets(planBucket.id).buildRequest().get();
428428
IPlannerBucketRequest bucketReq = testBase.graphClient.planner().buckets(planBucket.id).buildRequest();
429-
bucketReq.addHeader("If-Match", getEtag(bucket.getRawObject()));
429+
bucketReq.addHeader("If-Match", bucket.etag);
430430
bucketReq.delete();
431431

432432
//Fails with 403 Forbidden
@@ -435,11 +435,4 @@ public static void tearDown() throws InterruptedException {
435435
// planReq.addHeader("If-Match", getEtag(plan.getRawObject()));
436436
// planReq.delete();
437437
}
438-
439-
public static String getEtag(JsonObject obj) {
440-
String etag = obj.get("@odata.etag").toString();
441-
etag = etag.substring(1, etag.length()-1);
442-
etag = etag.replace("\\", "");;
443-
return etag;
444-
}
445438
}

0 commit comments

Comments
 (0)