Merge branch 'master' into raw-type-cleanup

Author: Caitlin Bales (MSFT)

README.md

@@ -1,21 +1,23 @@
 # Preview Microsoft Graph SDK for Java
+
 This client library is currently in private preview status. This means that: 
-- The API surface may change significantly
-- Non-blocking issues *may* be triaged at a slower pace
-- You may submit feedback through issues or PRs. You will have a better chance of your changes being implemented if they are submitted before public preview release
-- We do not define an SLA or support strategy for this library
+- The API surface may change significantly.
+- Non-blocking issues *may* be triaged at a slower pace.
+- You may submit feedback through issues or PRs. You will have a better chance of your changes being implemented if they are submitted before public preview release.
+- We do not define an SLA or support strategy for this library.
 
 We welcome your feedback as we drive the quality of this to general availability.
 
-# Get started with the Microsoft Graph SDK for Java
-
-Integrate the [Microsoft Graph API](https://graph.microsoft.io/en-us/getting-started) into your Java application!
+Get started with the Microsoft Graph SDK for Java by integrating the [Microsoft Graph API](https://graph.microsoft.io/en-us/getting-started) into your Java application!
 
 ## 1. Installation
+
 ### 1.1 Install via Gradle
-*This package will not be available via Gradle until it hits public preview. You will need to download the source and reference the package locally.*
 
-Add the JCenter repository and a compile dependency for `microsoft-graph` to your project's `build.gradle`
+> [!NOTE] 
+> This package will not be available via Gradle until it is in public preview. You need to download the source and reference the package locally.
+
+Add the JCenter repository and a compile dependency for `microsoft-graph` to your project's `build.gradle`:
 
 ```gradle
 repository {
@@ -29,28 +31,25 @@ dependency {
 ```
 
 ### 1.2 Enable ProGuard (Android)
-The nature of the Graph API is such that the SDK needs quite a large set of classes to describe its functionality. You will need to ensure that [ProGuard](https://developer.android.com/studio/build/shrink-code.html) is enabled on your project. Otherwise, you will incur long build times for functionality that is not necessary relevant to your particular application. If you are still hitting the 64k method limit, you can also enable [multidexing](https://developer.android.com/studio/build/multidex.html).
+The nature of the Graph API is such that the SDK needs quite a large set of classes to describe its functionality. You need to ensure that [ProGuard](https://developer.android.com/studio/build/shrink-code.html) is enabled on your project. Otherwise, you will incur long build times for functionality that is not necessarily relevant to your particular application. If you are still hitting the 64K method limit, you can also enable [multidexing](https://developer.android.com/studio/build/multidex.html).
 
 ## 2. Getting started
 
 ### 2.1 Register your application
 
-Register your application by following [these](https://developer.microsoft.com/en-us/graph/docs/concepts/auth_register_app_v2) steps.
+Register your application by following the steps at [Register your app with the Azure AD v2.0 endpoint](https://developer.microsoft.com/en-us/graph/docs/concepts/auth_register_app_v2).
 
 ### 2.2 Create an IAuthenticationProvider object
 
-An instance of the **GraphServiceClient** class handles building requests,
-sending them to the Microsoft Graph API, and processing the responses. To create a
-new instance of this class, you need to provide an instance of
-`IAuthenticationProvider` which can authenticate requests to Microsoft Graph.
+An instance of the **GraphServiceClient** class handles building requests, sending them to the Microsoft Graph API, and processing the responses. To create a new instance of this class, you need to provide an instance of `IAuthenticationProvider`, which can authenticate requests to Microsoft Graph.
 
-For an example of authentication in a client application see the [MSGraph SDK Android MSA Auth for Android Adapter](https://github.com/microsoftgraph/msgraph-sdk-android-msa-auth-for-android-adapter).
+For an example of authentication in a client application, see the [MSGraph SDK Android MSA Auth for Android Adapter](https://github.com/microsoftgraph/msgraph-sdk-android-msa-auth-for-android-adapter).
 
 ### 2.3 Get a GraphServiceClient object
 
-TODO: the para below needs expansion or removal. Would need to mention the different flows (authorization code flow, implicit flow, client credential flow) and give pointers on where to get sample code. Dave Moten can provide link for client credentials flow.
+<!--TODO: the following para needs expansion or removal. Would need to mention the different flows (authorization code flow, implicit flow, client credential flow) and give pointers on where to get sample code. Dave Moten can provide link for client credentials flow.-->
 
-Once you have set the correct application ID and url, you must get a **GraphServiceClient** object to make requests against the service. The SDK will store the account information for you, but when a user logs on for the first time, it will invoke UI to get the user's account information.
+After you have set the correct application ID and URL, you must get a **GraphServiceClient** object to make requests against the service. The SDK stores the account information for you, but when a user signs in for the first time, it invokes the UI to get the user's account information.
 
 ```java
 IClientConfig clientConfig = 
@@ -64,9 +63,9 @@ IGraphServiceClient graphClient =
 
 ## 3. Make requests against the service
 
-Once you have a GraphServiceClient that is authenticated you can begin making calls against the service. The requests against the service look like our [REST API](https://developer.microsoft.com/en-us/graph/docs/concepts/overview).
+After you have a GraphServiceClient that is authenticated, you can begin making calls against the service. The requests against the service look like our [REST API](https://developer.microsoft.com/en-us/graph/docs/concepts/overview).
 
-### Get the user's drive
+### 3.1 Get the user's drive
 
 To retrieve the user's drive:
 
@@ -89,14 +88,14 @@ For a general overview of how the SDK is designed, see [overview](https://github
 
 ## 4. Documentation
 
-For a more detailed documentation see:
+For more detailed documentation, see:
 
 * [Overview](https://github.com/microsoftgraph/msgraph-sdk-java/wiki/Overview)
 * [Extending the library](https://github.com/microsoftgraph/msgraph-sdk-java/wiki/Extending-the-Library)
 * [Handling Open Types, PATCH support with `null` values](https://github.com/microsoftgraph/msgraph-sdk-java/wiki/Working-with-Open-Types)
 * [Collections](https://github.com/microsoftgraph/msgraph-sdk-java/wiki/Working-with-Collections)
-* [Making Custom Requests](https://github.com/microsoftgraph/msgraph-sdk-java/wiki/Custom-Requests)
-* [Known Issues](https://github.com/microsoftgraph/msgraph-sdk-java/wiki/Known-Issues)
+* [Making custom requests](https://github.com/microsoftgraph/msgraph-sdk-java/wiki/Custom-Requests)
+* [Known issues](https://github.com/microsoftgraph/msgraph-sdk-java/wiki/Known-Issues)
 * [Contributions](https://github.com/microsoftgraph/msgraph-sdk-java/blob/master/CONTRIBUTING.md)
 
 ## 5. Issues
@@ -105,15 +104,15 @@ For known issues, see [issues](https://github.com/MicrosoftGraph/msgraph-sdk-jav
 
 ## 6. Contributions
 
-The Microsoft Graph SDK is open for contribution. Please read how to contribute to this project [here](https://github.com/microsoftgraph/msgraph-sdk-java/blob/master/CONTRIBUTING.md).
+The Microsoft Graph SDK is open for contribution. To contribute to this project, see [Contributing](https://github.com/microsoftgraph/msgraph-sdk-java/blob/master/CONTRIBUTING.md).
 
-## 7. Supported Java Versions
+## 7. Supported Java versions
 The Microsoft Graph SDK for Java library is supported at runtime for Java 7+ and [Android API revision 15](http://source.android.com/source/build-numbers.html) and greater.
 
 ## 8. License
 
 Copyright (c) Microsoft Corporation. All Rights Reserved. Licensed under the [MIT license](LICENSE).
 
-## 9. Third Party Notices
+## 9. Third-party notices
 
-[Third Party Notices](THIRD%20PARTY%20NOTICES)
+[Third-party notices](THIRD%20PARTY%20NOTICES)

src/main/java/com/microsoft/graph/concurrency/SimpleWaiter.java

@@ -53,6 +53,7 @@ protected boolean hasParameter(final String name) {
      * @param <T>  The type to which this object should be cast
      * @return The stored instance of T, otherwise null
      */
+    @SuppressWarnings("unchecked")
     protected <T> T getParameter(final String name) {
         return (T) bodyParams.get(name);
     }

src/main/java/com/microsoft/graph/core/BaseActionRequestBuilder.java

@@ -27,6 +27,8 @@
  */
 public class ClientException extends RuntimeException {
 
+    private static final long serialVersionUID = -1066560879567392559L;
+
     /**
      * Creates the client exception.
      * @param message The message to display.

src/main/java/com/microsoft/graph/core/ClientException.java

@@ -106,7 +106,7 @@ public IHttpProvider getHttpProvider() {
                     getAuthenticationProvider(),
                     getExecutors(),
                     getLogger());
-            logger.logDebug("Created DefaultHttpProvider");
+            getLogger().logDebug("Created DefaultHttpProvider");
         }
         return httpProvider;
     }
@@ -120,7 +120,7 @@ public IHttpProvider getHttpProvider() {
     public ISerializer getSerializer() {
         if (serializer == null) {
             serializer = new DefaultSerializer(getLogger());
-            logger.logDebug("Created DefaultSerializer");
+            getLogger().logDebug("Created DefaultSerializer");
         }
         return serializer;
     }
@@ -134,7 +134,7 @@ public ISerializer getSerializer() {
     public IExecutors getExecutors() {
         if (executors == null) {
             executors = new DefaultExecutors(getLogger());
-            logger.logDebug("Created DefaultExecutors");
+            getLogger().logDebug("Created DefaultExecutors");
         }
         return executors;
     }

src/main/java/com/microsoft/graph/core/DefaultClientConfig.java

@@ -50,8 +50,6 @@ public abstract class BaseRequestBuilder implements IRequestBuilder {
      */
     private final List<Option> options = new ArrayList<>();
 
-    private final IJsonBackedObject body;
-
     /**
      * Creates the request builder.
      *
@@ -66,23 +64,6 @@ public BaseRequestBuilder(
     ) {
         this.requestUrl = requestUrl;
         this.client = client;
-        this.body = null;
-
-        if (options != null) {
-            this.options.addAll(options);
-        }
-    }
-
-    public BaseRequestBuilder(
-            final String requestUrl,
-            final IJsonBackedObject body,
-            final IBaseClient client,
-            final List<? extends Option> options
-    ) {
-        this.requestUrl = requestUrl;
-        this.client = client;
-        this.body = body;
-
         if (options != null) {
             this.options.addAll(options);
         }

src/main/java/com/microsoft/graph/http/BaseRequestBuilder.java

@@ -29,6 +29,8 @@
  */
 public class GraphFatalServiceException extends GraphServiceException {
 
+    private static final long serialVersionUID = -4974392424026672738L;
+
     /**
      * Create a fatal Graph service exception.
      * @param method The method that caused the exception.

src/main/java/com/microsoft/graph/http/GraphFatalServiceException.java

@@ -42,6 +42,8 @@
  */
 public class GraphServiceException extends ClientException {
 
+    private static final long serialVersionUID = -7416427229421064119L;
+
     /**
      * New line delimiter.
      */

src/main/java/com/microsoft/graph/http/GraphServiceException.java

@@ -22,7 +22,6 @@
 
 package com.microsoft.graph.logger;
 
-import java.util.logging.Level;
 import java.util.logging.Logger;
 
 /**

src/main/java/com/microsoft/graph/logger/DefaultLogger.java

@@ -41,10 +41,6 @@ public final AdditionalDataManager additionalDataManager() {
         return additionalDataManager;
     }
 
-    public BaseAlternativeSecurityId() {
-        oDataType = "microsoft.graph.alternativeSecurityId";
-    }
-
     /**
      * The Type.
      *