Skip to content

Commit aad22fe

Browse files
calebkiagebaywet
authored andcommitted
ci: update release github action
1 parent eee0679 commit aad22fe

File tree

2 files changed

+22
-12
lines changed

2 files changed

+22
-12
lines changed

.github/workflows/git-release.yml

Lines changed: 19 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,24 @@ jobs:
2222
event: push
2323
name: drop
2424
path: drop
25-
- name: Github Release
26-
uses: anton-yurchenko/[email protected]
27-
env:
28-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
29-
DRAFT_RELEASE: "false"
30-
PRE_RELEASE: "false"
31-
CHANGELOG_FILE: "CHANGELOG.md"
32-
ALLOW_EMPTY_CHANGELOG: "true"
25+
## TODO: Confirm that the old action can update an existing release.
26+
# - name: Github Release
27+
# uses: anton-yurchenko/[email protected]
28+
# env:
29+
# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
30+
# DRAFT_RELEASE: "false"
31+
# PRE_RELEASE: "false"
32+
# CHANGELOG_FILE: "CHANGELOG.md"
33+
# ALLOW_EMPTY_CHANGELOG: "true"
34+
# with:
35+
# args: |
36+
# drop/build/**/*.jar
37+
# This action works with an existing release (created by the release bot) and uploads the build artifacts
38+
- name: GitHub Release
39+
uses: softprops/action-gh-release@v2
40+
if: startsWith(github.ref, 'refs/tags/')
3341
with:
34-
args: |
42+
token: ${{ secrets.GITHUB_TOKEN }}
43+
fail_on_unmatched_files: true
44+
files: |
3545
drop/build/**/*.jar

.github/workflows/release-please.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,15 @@ permissions:
77
contents: write
88
pull-requests: write
99

10-
name: release-please
10+
name: release-bot
1111

1212
jobs:
1313
release-please:
1414
runs-on: ubuntu-latest
1515
steps:
1616
- uses: google-github-actions/release-please-action@v4
1717
with:
18-
token: ${{ secrets.RELEASE_PLEASE_TOKEN }} # TODO: Create this token with repo
19-
config-file: release-please-config.json # Set to update gradle.properties & pom.xml
18+
token: ${{ secrets.RELEASE_PLEASE_TOKEN }}
19+
config-file: release-please-config.json # Set to update gradle.properties, pom.xml & CHANGELOG.md
2020
manifest-file: .release-please-manifest.json
2121
target-branch: dev

0 commit comments

Comments
 (0)