Skip to content

Commit df892dd

Browse files
committed
- improves unit test to test aspects and not just containing information
1 parent 0fae6e0 commit df892dd

File tree

1 file changed

+20
-9
lines changed

1 file changed

+20
-9
lines changed

src/test/java/com/microsoft/graph/serializer/AdditionalDataTests.java

Lines changed: 20 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
import static org.junit.Assert.assertNull;
77
import static org.junit.Assert.assertTrue;
88

9-
import com.microsoft.graph.models.extensions.*;
109
import org.junit.Before;
1110
import org.junit.Test;
1211

@@ -19,6 +18,18 @@
1918
import com.microsoft.graph.functional.TestBase;
2019
import com.microsoft.graph.http.HttpMethod;
2120
import com.microsoft.graph.logger.DefaultLogger;
21+
import com.microsoft.graph.models.extensions.ChatMessage;
22+
import com.microsoft.graph.models.extensions.ChatMessageMention;
23+
import com.microsoft.graph.models.extensions.Drive;
24+
import com.microsoft.graph.models.extensions.DriveItemCreateUploadSessionBody;
25+
import com.microsoft.graph.models.extensions.DriveItemUploadableProperties;
26+
import com.microsoft.graph.models.extensions.Entity;
27+
import com.microsoft.graph.models.extensions.IdentitySet;
28+
import com.microsoft.graph.models.extensions.PlannerAssignment;
29+
import com.microsoft.graph.models.extensions.PlannerAssignments;
30+
import com.microsoft.graph.models.extensions.PlannerTask;
31+
import com.microsoft.graph.models.extensions.PlannerTaskDetails;
32+
import com.microsoft.graph.models.extensions.User;
2233

2334
import java.util.Collections;
2435

@@ -147,17 +158,17 @@ public void testHashMapProperties() {
147158

148159
@Test
149160
public void testSerializeAdditionalDataOnCollections() {
150-
ChatMessage chatMessage = new ChatMessage();
151-
ChatMessageMention chatMessageMention = new ChatMessageMention();
161+
final ChatMessage chatMessage = new ChatMessage();
162+
final ChatMessageMention chatMessageMention = new ChatMessageMention();
152163
chatMessageMention.additionalDataManager().put("helloWorld", new JsonPrimitive("3.141516"));
153-
IdentitySet identitySet = new IdentitySet();
164+
final IdentitySet identitySet = new IdentitySet();
154165
identitySet.additionalDataManager().put("identitySetKey", new JsonPrimitive("identitySetValue"));
155166
chatMessageMention.mentioned = identitySet;
156167
chatMessage.mentions = Collections.singletonList(chatMessageMention);
157-
String output = serializer.serializeObject(chatMessage);
158-
assertTrue(output.contains("helloWorld"));
159-
assertTrue(output.contains("3.141516"));
160-
assertTrue(output.contains("identitySetKey"));
161-
assertTrue(output.contains("identitySetValue"));
168+
final String output = serializer.serializeObject(chatMessage);
169+
final JsonObject parsed = JsonParser.parseString(output).getAsJsonObject();
170+
final JsonObject mentionJsonObject = parsed.get("mentions").getAsJsonArray().get(0).getAsJsonObject();
171+
assertEquals("3.141516", mentionJsonObject.get("helloWorld").getAsString());
172+
assertEquals("identitySetValue", mentionJsonObject.get("mentioned").getAsJsonObject().get("identitySetKey").getAsString());
162173
}
163174
}

0 commit comments

Comments
 (0)