Skip to content
This repository was archived by the owner on Apr 18, 2023. It is now read-only.

Commit 29c12a5

Browse files
author
Vikas Dadheech
committed
Resolved further review comments -
- Added comment on the limit of maximum number of requests - Added space around > character - Removed extra space after ; character at 4 places
1 parent 32a7520 commit 29c12a5

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

MSGraphCoreSDK/MSGraphCoreSDK/GraphContent/BatchContent/MSBatchRequestContent.m

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,10 @@ - (instancetype)initWithRequests:(NSArray<MSBatchRequestStep *> *)batchRequestSt
2323
self = [super init];
2424
if(self)
2525
{
26+
//Batch requests are currently limited to 20 individual requests by Graph server.
2627
maxNumberOfRequests = 20;
2728
//Check whether number of request steps in array are more than the limit
28-
if(batchRequestStepsArray.count>maxNumberOfRequests)
29+
if(batchRequestStepsArray.count > maxNumberOfRequests)
2930
{
3031
NSDictionary *userInfo = @{
3132
NSLocalizedDescriptionKey: MSErrorStringMaximumBatchStepLimitReachedDescription,
@@ -92,10 +93,10 @@ - (void)addBatchRequestStep:(MSBatchRequestStep *)requestStep error:(NSError *__
9293
- (void)removeBatchRequesStepWithId:(NSString *)requestId error:(NSError *__autoreleasing *)error
9394
{
9495
BOOL didFindStep = NO;
95-
for (long i = _batchRequestStepsArray.count-1 ; i >= 0 ; i--)
96+
for (long i = _batchRequestStepsArray.count-1; i >= 0; i--)
9697
{
9798
MSBatchRequestStep *requestStep = _batchRequestStepsArray[i];
98-
for (long j = requestStep.arrayOfDependsOnIds.count-1 ; j >= 0 ; j--)
99+
for (long j = requestStep.arrayOfDependsOnIds.count-1; j >= 0; j--)
99100
{
100101
NSString *dependsOnId = requestStep.arrayOfDependsOnIds[j];
101102
if([dependsOnId isEqualToString:requestId])

0 commit comments

Comments
 (0)