Skip to content
This repository was archived by the owner on Apr 18, 2023. It is now read-only.

Commit 5d974e0

Browse files
author
Vikas Dadheech
committed
Changed request to hold mutable copy and added unit tests to test the same
1 parent 8825623 commit 5d974e0

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

MSGraphCoreSDK/MSGraphCoreSDK/Common/Session Tasks/MSURLSessionTask.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ - (instancetype)initWithRequest:(NSMutableURLRequest *)request
2424
if (self)
2525
{
2626
_client = client;
27-
_request = request;
27+
_request = [request mutableCopy];
2828
}
2929
return self;
3030
}

MSGraphCoreSDK/MSGraphCoreSDKTests/SessionTask/MSURLSessionTaskTests.m

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,17 @@ - (void)testInitFailsWithNilRequest{
4040
XCTAssertThrows([[MSURLSessionTask alloc] initWithRequest:nil client:self.mockClient]);
4141
}
4242

43-
- (void)testInitMSURLSessionTaskState{
43+
- (void)testInitWithNonMutableRequest {
44+
NSURLRequest *urlRequest = [NSURLRequest requestWithURL:self.testBaseURL];
45+
MSURLSessionTask *sessionTask = [[MSURLSessionTask alloc] initWithRequest:urlRequest client:self.mockClient];
46+
XCTAssertTrue([sessionTask.request isKindOfClass:[NSMutableURLRequest class]]);
47+
XCTAssertNotEqual(urlRequest, sessionTask.request);
48+
}
49+
50+
- (void)testInitMSURLSessionTask{
4451
MSURLSessionTask *msURLSessionTask= [[MSURLSessionTask alloc] initWithRequest:self.requestForMock client:self.mockClient];
4552
XCTAssertEqual(msURLSessionTask.client, self.mockClient);
53+
XCTAssertNotEqual(msURLSessionTask.request, self.requestForMock);
4654
}
4755

4856
- (void)testSetInnerTask{

0 commit comments

Comments
 (0)