Skip to content
This repository was archived by the owner on Apr 18, 2023. It is now read-only.

Commit e39f7c3

Browse files
author
Vikas Dadheech
committed
Resolved review comments -
- Alphabetical order for Middleware type enum - Moved default values in RetryHandler as part of #define portion of file
1 parent 4f43c1f commit e39f7c3

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

MSGraphCoreSDK/MSGraphCoreSDK/HTTPClient/MSMiddlewareFactory.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313
typedef NS_ENUM(NSInteger, MSMiddlewareType)
1414
{
1515
MSMiddlewareTypeAuthentication,
16-
MSMiddlewareTypeRedirect,
1716
MSMiddlewareTypeHTTP,
17+
MSMiddlewareTypeRedirect,
1818
MSMiddlewareTypeRetry
1919
};
2020

MSGraphCoreSDK/MSGraphCoreSDK/Middleware/Implementations/RetryHandler/MSRetryHandler.m

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111
NSString * const TRANSFER_ENCODING = @"Transfer-Encoding";
1212

1313
#define DELAY_SECONDS 10;
14+
#define DEFAULT_MAX_RETRIES 10;
15+
#define DEFAULT_RETRY_POWER 1;
1416

1517
@interface MSURLSessionTask()
1618

@@ -35,8 +37,8 @@ - (instancetype)init
3537
self = [super init];
3638
if(self)
3739
{
38-
maxRetries = 10;
39-
retryPower = 1;
40+
maxRetries = DEFAULT_MAX_RETRIES;
41+
retryPower = DEFAULT_RETRY_POWER;
4042
}
4143
return self;
4244
}

0 commit comments

Comments
 (0)