Skip to content

Commit 219a288

Browse files
committed
updates
1 parent 07f0a50 commit 219a288

File tree

2 files changed

+10
-28
lines changed

2 files changed

+10
-28
lines changed

config/ModuleMetadata.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,15 @@
2727
"versions": {
2828
"authentication": {
2929
"prerelease": "",
30-
"version": "2.27.3"
30+
"version": "2.27.4"
3131
},
3232
"beta": {
3333
"prerelease": "",
34-
"version": "2.27.3"
34+
"version": "2.27.4"
3535
},
3636
"v1.0": {
3737
"prerelease": "",
38-
"version": "2.27.3"
38+
"version": "2.27.4"
3939
}
4040
}
4141
}

tools/Custom/ModelExtensions.cs

Lines changed: 7 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -60,35 +60,17 @@ public static async Task EnsurePropertiesAreReady(
6060

6161
private static bool IsUnready(object model, PropertyInfo prop, MethodInfo isPropertySetMethod, bool failOnExplicitNulls)
6262
{
63-
try
64-
{
65-
// Ensure method matches expected signature
66-
var parameters = isPropertySetMethod.GetParameters();
67-
if (parameters.Length != 1 || parameters[0].ParameterType != typeof(string))
68-
{
69-
Console.WriteLine($"WARNING: IsPropertySet signature mismatch for type {model.GetType().Name}");
70-
return false;
71-
}
72-
73-
bool isSet = (bool)isPropertySetMethod.Invoke(model, new object[] { prop.Name });
74-
if (!isSet) return false;
63+
bool isSet = (bool)isPropertySetMethod.Invoke(model, new object[] { prop.Name });
64+
if (!isSet) return false; // not marked as set, skip
7565

76-
object value = prop.GetValue(model);
77-
Console.WriteLine($"DEBUG: {prop.Name} = {value}, IsSet: {isSet}");
66+
object value = prop.GetValue(model);
67+
68+
if (value == null)
69+
return failOnExplicitNulls; // null is OK in relaxed mode, fail in strict
7870

79-
if (value == null)
80-
return failOnExplicitNulls;
81-
82-
return IsDefault(value);
83-
}
84-
catch (Exception ex)
85-
{
86-
Console.WriteLine($"ERROR: Failed to check IsPropertySet for {prop.Name}{ex.Message}");
87-
return false;
88-
}
71+
return IsDefault(value);
8972
}
9073

91-
9274
private static bool IsDefault(object value)
9375
{
9476
Type type = value.GetType();

0 commit comments

Comments
 (0)